KeyControl: init keylock from config, fix pitchRatio rounding issue#4756
Merged
daschuer merged 3 commits intomixxxdj:2.3from May 12, 2022
Merged
KeyControl: init keylock from config, fix pitchRatio rounding issue#4756daschuer merged 3 commits intomixxxdj:2.3from
daschuer merged 3 commits intomixxxdj:2.3from
Conversation
2 tasks
Member
|
There is a clang format issue. |
ronso0
force-pushed
the
keylock-fix-simple
branch
from
25c70e6 to
8a7ced3
Compare
Member
|
I just did a brief test and it works good. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the two first bugfix commits from #4710, + debug output
Keylock ON not considered after start
https://bugs.launchpad.net/mixxx/+bug/1943180
Internal
m_pitchRateInfo.keylockis updated only inKeyControl::updateRate()when any rate, keylock or vc controls are touched. Though, it may be requested by EngineBuffer prior to that, e.g when nudging a track, which results in a temporary keychange.Also, with keylock enabled after start, the first call of
KeyControl::updateRate()would interpret the update as keylock change which seems to affectm_pitchRateInfomembers unintentionally.Fix: update
m_pitchRateInfo.keylockwhen initializingSudden false-positive pitch offset when unlocking key, see #4710 (comment)
probably regression from #1222
Fix: round pitchRatio if it's veeeery close to 1.0