Support multiple library folders.#21
Conversation
Because Fieldscaper add '' marks around a direcotry entry Qt can't work with them straight after I get them out of the library. To make everything work again I just need to replace ' with an empty string
There was a problem hiding this comment.
I'm having problems with this part of the code. When I run the relocation query inside of mixxx it does not work. But when I use the generated query directly with sqlite3 everything is fine. This worked before so I have no clue what the error might be
There was a problem hiding this comment.
You're probably hitting issues because the column values are double-escaped (see my other comments on using FieldEscaper).
(Also, the commented bindValues below don't need FieldEscaper)
|
Thanks! I think you can test the symlinks using QFile::link to create links between your temp directories. As for the slashes, Qt definitely handles this for us. This is slightly embarrassing but I couldn't figure out how to push the latest winlib with TortoiseBzr. It kept failing and I gave up a few months ago. I'll try again. |
|
OK, I pushed the latest 1.12 dependencies here: https://github.com/mixxxdj/winlib. It was high time we ditched Bazaar for hosting winlib anyway. |
|
Ah nice. I updated the wiki with the new location of winlib. I'll have time on the weekend to test everything |
|
Cool - I actually think it'd be fine if you merge it now (after fixing the other minor comments I made). Qt definitely handles the path separators for us (we would have had tons of other problems if it didn't). Plus any fixes there wouldn't be to the data model so it wouldn't risk corrupting user data for those running at HEAD. I'd like to merge this before features_key so that you don't have to deal w/ merge conflicts :). |
|
Ok I fixed your last comments. You can merge it if you want. It will take me some time to get the tests running on windows. |
|
Great, thanks! |
Support multiple library folders.
There was a problem hiding this comment.
Hi @kain88-de,
It looks like we have merge issues on this file in master now.
Can you have a look at it?
What is:
Support Mixxx by counting and sharing bundled song playback and outbound link statistics
Haven't we removed it?
There was a problem hiding this comment.
what merge conflict? for me everything works fine.
There was a problem hiding this comment.
Ah, you have fixed the promo issues in master. I have now fixes the external library alignment as well. So this issue is solved.
QT < 5.6 compatible getDevicePixelRatioF()
Update downloads page with RC1 links and analytics conversions.
…xdj#21) New for this year, but would be wildly useful to us at Google at least. I don't imagine it would be too difficult, except perhaps extending the output type (and thus perhaps input types in various parts of the pipeline). Perhaps some of that can be hacked away by providing a new function that gets/sends packets in this way instead of changing the type of current functions. Signed-off-by: Jonathan DiLorenzo <jonathan.dilorenzo@gmail.com> Signed-off-by: Bili Dong <qobilidop@gmail.com> Co-authored-by: Bili Dong <qobilidop@gmail.com>
4 participants
Enable Mixxx to handle several Library Folders and add an option to move them to another location without dataloss.
Directories can also be added from the browse-view