-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Support multiple library folders. #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
91 commits
Select commit
Hold shift + click to select a range
096fe2f
multiply Library Folders feature from library_features branch, builds…
6155f3f
fixed update code and removed useless stuff from initial patch
36d5dfd
dlgprefplaylist uses library instance instead of sql connection
5981597
basic track adding works
d605e8c
directoryDAO query don't work with bindvalue
6cd27e2
directory doa works with bindValue now
667d90e
remove checksums from schema.xml
23c4611
code clean up
afa8e43
remove relocate feature
588e6cc
Merge branch 'master' into multiplyFolders
de9357a
remove more code
ee2019b
remove more code
a103513
added MAINDIR_ID to missingtablemodel.cpp
edec5e2
clean up mess
2ca37f0
Merge branch 'master' into multiplyFolders
2f48da4
remove old merge conflicts
63b1349
still problems with relocating a directory
fc4217a
Merge branch 'master' into multiplyFolders
e7155e8
Merge branch 'master' into multiplyFolders
31457ec
merge with master branch
168a445
Merge branch 'master' into multiplyFolders
e28c83b
Merge branch 'master' into multiplyFolders
kain88-de e34367b
Merge remote-tracking branch 'upstream/master' into multiplyFolders
c6fc3b3
readd library scheme to allow for several directories
8e6434a
try to fix relocate query
d44c8ec
address rryans style comments
5f3c681
Merge remote-tracking branch 'upstream/master' into multiplyFolders
f42f5b9
removed main_dirId
kain88-de ece192a
split dirsChanged signal into 3 seperate signals
kain88-de 89b2e60
prepend request add/remove/... signals
kain88-de 617e95c
mark tracks as mixxx_deleted instead of purgin them
kain88-de 0a603f4
rename buttons in dlgprefplaylist
kain88-de 7160634
give some more meaningful variable name and reselect old index based …
7e4f0fa
if we already track the parent directory do not add new dir
858dded
remove unused code
bed5201
more clean up
8cee6b7
tidy up a bit more
9294917
better commits
51a5eec
relocate seems to work, their still is a problem with loaded tracks
4639c9d
enable downgrading
31f6f30
merge with upstream
b68724a
add comment about library scan
b8ed1cb
merge with upstream/master
560f721
also update BaseTrackCache
3d2455c
Merge branch 'master' into features_multifolder
rryan 9270b78
Use reference for m_database.
rryan 7507202
Fix markTracksAsMixxxDeleted (query was not valid SQL).
rryan 11c2834
Use common #define for legacy library location.
rryan 0e9a03f
Re-order initialization.
rryan fd6f541
Cleanups to DirectoryDao.
rryan 8875252
General cleanups.
rryan a3e8fe5
Word-smithing.
rryan b18a96d
QSqlQuery::bind doesn't work for embedding things inside parantheses.
rryan 6b8d921
Get rid of asserts in detectMovedFiles. Use pointers for arguments th…
rryan 5f9c332
Abort transaction instead of committing when a cancel signal is recei…
rryan c9ed252
Add warning to Max about track_locations ids not being library ids.
rryan 5ac81de
Random cleanups.
rryan 5d313d7
Switch to LIKE instead of instr which isn't present on all SQLite sys…
rryan 83b5a7d
Get rid of transaction in verifyRemainingTracks now that it is called…
rryan a409ca5
Warn about calling main TrackDAO from library scanner thread.
rryan 0e33e2e
Add rollback support to addTracksFinish.
rryan 3418fbc
Remove use of instr in favor of LIKE. instr isn't supported on the mo…
rryan aaf95e9
Add TODO for error reporting.
rryan 19664ee
Use directory for starting point in relocation if it still exists (or…
rryan 67ac323
merge with upstream/master
e224ae3
Merge remote-tracking branch 'upstream/master' into multiplyFolders
d447305
add directorydao test
c98df40
test from empty sql file
0c45d3d
proper TearDown of tests
6055128
test removeDir
a9724d9
added test for getDirs
67751b7
use a db for testing
7c09f0c
return more error codes in direcotryDAO
2a1b485
check for child dir in addDirectory
9dbcdf4
check dir equality with QDir
232f554
fix sql statement
0c78e6d
start to enter test for relocateDir
cb1ebef
clean the whole database after each test
9c4bb1d
directoryDao now handles parent dirs correctly
e2bfb3c
Fix directorydao:replace function
061838f
Merge remote-tracking branch 'upstream/master' into multiplyFolders
a785a84
clean up diff
8d78d5b
add all watched folders to browse quicklink
cfadda6
Add message box when removing watched directory
a7880e8
minor clean ups
c8be27d
relocateDirTest does some checks
06fc481
Merge remote-tracking branch 'upstream/master' into multiplyFolders
0f5974e
coding style in library preferences
00f97a4
Do sql commands in a transaction + small refactor
4de6580
change algorithm to detect child folders
5a38b92
Use QSet instead of Qlist to avoid duplicates
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,8 @@ | |
| .sconf_temp | ||
| .sconsign.branch | ||
| .sconsign.dblite | ||
| *.sqlite | ||
| *.cfg | ||
| cache | ||
| lib/*/*.a | ||
| lib/*/lib/*.a | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you user here list->model() instead of m_model?