Add option to disable EQ gain influence on waveforms#14998
Conversation
Adds a checkbox to preferences to toggle if EQ knob gain affects waveform rendering. Allows displaying waveform amplitude regardless of EQ knob positions.
|
Welcome and thanks for improving this! Please sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future. |
|
I've signed the agreement. |
Swiftb0y
left a comment
Swiftb0y
left a comment
There was a problem hiding this comment.
this looks very decent already. I have a couple requests:
Flipped the setting logic to "visualize EQ waveform". Fixed a logic issue where dead code was not skipped.
|
@Swiftb0y Addressed the points you brought up! Let me know if you notice anything else that I should fix. |
|
I mean there is the general issue that this setting only applies to some waveform types (RGB, Stacked) and not others, but all of those settings are shown regardless of whether they have an effect on the current type or not. Addressing this is not a requirement for this PR though (you're welcome to look into it in a follow up PR if you'd like to). |
|
I think it would be best to rely on Waveform option rather than adding a context-less setting. This will allows a better integration with the cleanup work we've made with @m0dB , prevent growing more config key and ease porting on QML/Mixxx 3.0 as not building on the WaveformFactory/dedicated config key. This should be straight forward to convert tho, as you can pretty much keep all the UI as is, just need to migrate the backend to use options! |
|
I initially thought the same, but there is slight issue that the waveform options are only a feature of the |
|
Indeed - I'm wondering if there is a middle ground we could reach, just to make sure we keep things clean. Let me see if I can move the option outside |
|
Hi @artiniest, waveform options should now be available outside of |
|
@artiniest do you have any plans (and time) to finish this feature? If not, I'll be willing to improve upon it based on the comments in this thread. |
|
@kruitbosdotdev I'm pretty busy with other projects at the moment so if you have the time to take this over the finishing line, that'd be great! |
|
For anyone continuing here, a small UI request: |
|
Unfotunately there are merge conflicts now. Looks easy to fix though. |
I've pushed a PR which merges this with the latest main branch and fixes a bug in how the default value was set. Seems to work ok now but @artiniest will have to merge my PR first. If we don't hear back I can open a new PR for this too. |
I take that back. It messes up the regular gain influence rendering when enabled. Investigating now... |
|
Please also note the feedback for RGB types is broken. Here is the fix: |
Ah yes... that explains it then. I merged that PR on top of mine and everything is looking good now. One thing I noticed is that the original PR for this retains a test that keeps getting removed and added back with various merges in main. In The test for |
7 participants
Adds a new option in Preferences > Waveforms to disable the visible effect of EQ gain knobs on waveform rendering. Visual gain remains applied independently.
Feature request here