chore(waveform): migrate option to global namespace#15001
Merged
JoergAtGithub merged 1 commit intoJun 26, 2025
Conversation
acolombier
force-pushed
the
chore/migrate-waveform-opts
branch
from
9c6fa5c to
c38f734
Compare
Member
Author
acolombier
force-pushed
the
chore/migrate-waveform-opts
branch
from
c38f734 to
d0009e3
Compare
Swiftb0y
reviewed
Jun 24, 2025
Member
Swiftb0y
left a comment
Swiftb0y
left a comment
There was a problem hiding this comment.
this looks sensible, idk when I can take a proper look though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migration allows #14998 to leverage Waveform options instead of using bare config+WaveformFactory