Skip to content

Restore EQ scaling for RGB and HSV waveforms. #15808

Merged
ronso0 merged 5 commits into
mixxxdj:2.6from
daschuer:gh15788
Jan 14, 2026
Merged

Restore EQ scaling for RGB and HSV waveforms. #15808
ronso0 merged 5 commits into
mixxxdj:2.6from
daschuer:gh15788

Conversation

@daschuer
Copy link
Copy Markdown
Member

@daschuer daschuer commented Dec 31, 2025

This fixes #15788 a LOW-Kill action, with the new unscaled shadow:

Here you see a waveform with killed low end and Tango

grafik

@ronso0
Copy link
Copy Markdown
Member

ronso0 commented Dec 31, 2025

I can confirm this restores the previous behavior for the RGB renderer.

But why is the unscaled background wave now painted with the axis color? This does not make any sense to me, all band's 'shadows' look grey now.

Please restore the look from before #15324 where we can identify each unscaled band by color.


I didn't check the HSV renderer, yet, as I didn't ever use it and am not quite sure about the use case / expectations.

@ronso0 ronso0 linked an issue Dec 31, 2025 that may be closed by this pull request
@daschuer
Copy link
Copy Markdown
Member Author

You mean the RGB type, right? I will restore dimned version if the original waveform there.

@daschuer
Copy link
Copy Markdown
Member Author

Now RGB High Details type looks like this: (Top: low kill)
grafik

@ronso0
Copy link
Copy Markdown
Member

ronso0 commented Dec 31, 2025

Thanks, but not quite there, yet. This branch
image
And main my main-based branch. Alpha was 0.4 before. Slightly more opacity makes a difference when the waveforms are moving, and at night..
image

@daschuer daschuer added this to the 2.6.0 milestone Jan 1, 2026
@daschuer
Copy link
Copy Markdown
Member Author

daschuer commented Jan 1, 2026

OK changed to 40% Opacity.

@ronso0
Copy link
Copy Markdown
Member

ronso0 commented Jan 1, 2026

Thank you!
I'll need to do some prep in order to compare this and the state before #15324, which I hopefully manage to do next days.

@daschuer daschuer changed the title Restore EQ caling for RGB and HSV waveforms. Restore EQ scaling for RGB and HSV waveforms. Jan 6, 2026
@ronso0
Copy link
Copy Markdown
Member

ronso0 commented Jan 14, 2026

will test this evening!

Copy link
Copy Markdown
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fixup!
Waves look like before now

@ronso0
Copy link
Copy Markdown
Member

ronso0 commented Jan 14, 2026

Though there seems to be another change (regression IMO) with the preroll triangles.
Left is before #15324 ( I revert the commits from that PR on 2.5), right is 2.5/this PR
image || image

Where are those rendered?

@ronso0 ronso0 merged commit 93afe94 into mixxxdj:2.6 Jan 14, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RGB wave visualization broken in 2.6 latest update

2 participants