2.5.1 release

[daschuer]

This is the release PR for the Mixxx version 2.5.1
It contains some important bug-fixes and mapping updates.

These are my personal highlights:

• Fix scrolling issue with coverart columns visible Fix scrolling issue with coverart columns visible  #13719
• Deere (64 samplers): Bring back library in regular view (fix) Deere64: bring back library in regular view #14101 Deere64 - Library isn't showing on the application #14097
• Fix crash when hiding waveforms in Deere Fix crash when hiding waveforms in Deere #14170
• Fix MusicBrainz lookup on Windows and macOS Added missing QTlsBackendOpenSSLPlugin to make MusicBrainz work with Qt6 builds #14216
• Fix sporadic deadlocks when closing Mixxx or changing sound devices wait for the portaudio finished callback to avoid sporadic deadlocks #14208 hanging on quit (only once so far) #14055

I am also happy about these big effort involved publishing a new version after 3 Month.
Thank you to all contributiors.

@Eve00000 Next step is preparing a brief blog post.
Will you find time for this. I am curious about the style you will select.

[Eve00000]

I am curious about the style you will select.

Sure, but I don't want to block someone else's inspiration.
@acolombier wrote he wanted to make the videos for a future release, I assume he means a 'new features release'?
It's springtime ... I have a draft about animals getting active in their (github) nest, all in the David Attenborough style. You've read a draft of it. Would that be nice?

[daschuer]

Did you mean this, as David Attenborough style:
https://mixxx.org/news/2024-06-25-mixxx-2-5-beta-released/
Maybe you can reference this? Mixxx 3.5.1 is now adult ... :-)
Just an idea. A minor relase shall be anyway only ashort note.
We will have the 2.6.-beta shortly where some more exiting things (STEMs) are included.

[daschuer]

All Green, Smoke testing can be started.

[Eve00000]

Did you mean this ...

No.
this is the draft:

Imagine Sir David Attenborough reading this text to you.

Dawn of a day on the end of may, winter is coming to an end, spring is already announcing.
Plants plants raise their heads from the ground, others start showing a little bit of colour, trees are preparing to show blossoms.
Somewhere between those plants we find the home of a very rare species, here live the Mixxx-ers in their nest, called a github.
Let us take a closer look.
Oh we can see already a worker-Mixxx-er opening his eyes, still sleepy after the rather long short night.
Yesterday was a busy day for this worker-Mixxxer and so will be today.
Before even getting something to eat or drink he takes a seat at his computer and checks if there are new support issues, bug reports or feature demands.
Not yet really awake he stretches his fingers and places them gently on his keyboard. It's important that his fingers got slowly warmth up, they will type a lot and an accident can easy happen.
All the questions of the little Mixxx-ers need to be answered in a correct way and the answers certainly need to be complete.
A little bit further another worker-Mixxx-er is waking up and with half-open eyes he's grabbing his smartphone to check if there are urgent issues to deal with.
It looks like this is their ritual, after all worker-Mixxx-ers immediately grab their phone or take a screen to check the Mixxx-sites when they wake up.
Our first worker-Mixxx-er has already answered 5 forum-threads, his 10 fingers are typing like crazy because little Mixxx-ers are waking up and sending a lot of questions. It looks like our worker-Mixxx-er will be busy for quiet some time.
Yesterday one of the worker-Mixxx-ers rang the milestone-bell. This means that in a short time there has to be a new Mixxx-release, so all worker-Mixxx-ers got in coding-overdrive.
We're lucky, we will attend the birth of a new release: The Mixxx 2.5.1

This is the start of a funny story but it is not fiction.
In the Mixxx-Github code is flying at high speed.
A lot of work is being done on many PR's (pull requests), a lot of code is being reviewed, commented, rewritten, re-reviewed, adjusted...

David Attenborough is a well known BBC documentary maker who has a very typical voicetimbre that will be linked to nature-documentaries.

[daschuer]

😂 so lovely. I hear Heins Sielmann from German television.

I am unfotunatly in doubt that the length is appropiated for a bug fix release. Can we safe this for the 2.6.-beta that will be arrive next week or so, (before easter). I also think that the picture "new birth" does not fix well for a bug fix. I have more a reliable mother in mind where you can rely on even if you do stupid things.

But actually I don't want to interfere too much, and demand a specifc picture.

[Eve00000]

OK, you are right, let's save it for another (bigger) release.
I re-start my brain :-)

[m0dB]

I just merged #14491 to 2.5 (Hercules DJControl Inpulse 500 mappings). Do I need to do anything else so that makes it into 2.5.1, or is the merge enough?

I will also add the documentation for this mapping to the 2.5 manual.

[krisquigley]

I just merged #14491 to 2.5 (Hercules DJControl Inpulse 500 mappings). Do I need to do anything else so that makes it into 2.5.1, or is the merge enough?

I will also add the documentation for this mapping to the 2.5 manual.

I'd also love to see this in 2.5.1 if possible 🙏

[daschuer]

Nothing else to do. I will update the change log and rebase this 2.5 soon.
Could you do some smoke testing on macOs?

[PPN-SD]

Any chance to un-block taglib-2 for this release ?

[daschuer]

The tagline issue is target here #12854 do you want to help?

[PPN-SD]

The tagline issue is target here #12854 do you want to help?

I can try, My last attempt had failed to reproduce it but I see you have listed the steps, thank you.

[JoergAtGithub]

Can anybody confirm #14563, and if yes, is it 2.5.1 regression or a bug that exists in 2.5.0 too?

[uklotzde]

Can anybody confirm #14563, and if yes, is it 2.5.1 regression or a bug that exists in 2.5.0 too?

It is a regression.

[ronso0]

FYI there are two more fixes that may slip in last minute:
#14573 (easy to test)
#14556 (requires a bit more manual testing)

[ronso0]

Since we have a blocker (#14563) anyway, and the mapping has been approved, it can certainly slip in once the manual PR is ready.

Apart from that, from now on only bugfixes should be added.
Remember we can create a 2.5.2 release if enough fixes and/or new mappings have been added : )

[JoergAtGithub]

There seems to be a second blocker in the 2.5.1 blocker: #14606
=> Only crashes Controller Screen Support - not 2.5 relevant therefore

[acolombier]

I believe the last item is #14556 and this can go!

[daschuer]

Last chance for smoke testing. My goal is to merge this tonight.

[Eve00000]

Last chance for smoke testing. My goal is to merge this tonight.

Are the builds approved, all merged? Then I will start testing them.

[daschuer]

Yes, just now. I have just rebased on 2.5 to have also the latest translation update included.

[Eve00000]

Yes, just now. I have just rebased on 2.5 to have also the latest translation update included.

OK, I'll wait until they finished.
After the tests I will adapt the changelog in the release-post.

[daschuer]

License is now 2001-2025. I have removed the license form the find*.cmake files like we did with all other files to reduce yearly noise.

[acolombier]

All systems go!
Letting some time for other member to comment before merging...