Added missing QTlsBackendOpenSSLPlugin to make MusicBrainz work with Qt6 builds

[JoergAtGithub]

Closes: #14082

[ronso0]

Thanks for the quick fix!
I assume you tested this yourself, though it doesn't hurt to get verification from the reporter:
@vajimb Could you please test the fix?
Instructions for how to test CI builds are on the wiki https://github.com/mixxxdj/mixxx/wiki/Testing#github-pull-requests
To be safe, backup your database and settings: Backup instructions

[daschuer]

I think you need to add the plugin here as well:

mixxx/src/mixxxapplication.cpp

Line 52 in 675d427

Q_IMPORT_PLUGIN(QGifPlugin)

[vajimb]

This plug in is required to make MusicBrainz work with the newer version?

[vajimb]

What am I testing?

[ronso0]

What am I testing?

All info is in the links I posted earlier #14216 (comment)
You don't need to care about the plugin (that comment was for @JoergAtGithub), just backup up your settings as described to be safe, then download and install the CI build of this PR.

Maybe you don't see these links when you look at the email notification, but you sure do if you look at this PR webpage.
Btw Please, if you reply via email, try to hide the original message, it just adds noise here. Thank you!

[ronso0]

@JoergAtGithub unfortunately macOS doesn't link with the latest change.

[daschuer]

Oh something is broken regarding linking. We have:
Qt6/plugins/tls/objects-Release/QTlsBackendOpenSSLPlugin_init/QTlsBackendOpenSSLPlugin_init.cpp.o

But it is not listed in the link command like

Qt6/plugins/imageformats/objects-Release/QJpegPlugin_init/QJpegPlugin_init.cpp.o

The object has
qt_static_plugin_QTlsBackendOpenSSL()
but not the referenced
qt_static_plugin_QTlsBackendOpenSSLPlugin()

while
qt_static_plugin_QJpegPlugin()
is available

[daschuer]

A difference is in share/Qt6Network/Qt6QTlsBackendOpenSSLPluginTargets.cmake`

QT_PLUGIN_CLASS_NAME "QTlsBackendOpenSSL"

instead of

QT_PLUGIN_CLASS_NAME "QTlsBackendOpenSSLPlugin"

[daschuer]

I think this does the trick.

[daschuer]

LGTM, all green. Thank you for taking care.
Another PR rectifying immedit 2.5.1 release IMHO.
I hope I find time for wrapping that up.

[vajimb]

Perhaps this issue is still known to some. Musicbrainz still does NOT work out of the box on 2.5

IF it requires some sort of plugin or correction, please post instructions.

REQUEST: In the case where a user desires to revert back to a previous edition of Mixx, please allow this without having to unstall and reinstall.

Version
2.4.2 from 2.5

[ronso0]

@vajimb Did you test the CI builds as I wrote in #14330 (comment) ?

[vajimb]

No....my ability to 'test' is limited. I can wait. I was having a hard time understanding what the status of this problem is, I reverted back to 2.4.2 and I'm OK with that. Thanks

[ronso0]

No....my ability to 'test' is limited.

Alright, but with the instructions it's actually only a matter of minutes.

• backup your settings and database
• download and install the CI build
• test
• (in case it's still not working: uninstall, reinstall 2.4.2, restore the backup directory, have fun)