Add Hercules DJControl Inpulse 500 mapping by resetreboot · Pull Request #14316 · mixxxdj/mixxx

resetreboot · 2025-02-09T17:21:29Z

JoergAtGithub · 2025-02-09T19:25:13Z

Welcome at Mixxx!
As a first-time contributor we need you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

cr7pt0gr4ph7

A few small formatting nitpicks.

cr7pt0gr4ph7

A few actual code change suggestions as well as some more formatting nitpicks.

cr7pt0gr4ph7

I can't actually test this mapping as I don't have the associated hardware, though this seems to look good so far. The indentation should be fixed to only use spaces, though.

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

cr7pt0gr4ph7

Code looks good. I can't give any input on the problems brought up by @m0dB, though these should definitely be resolved before merging. I'll be happy to do a final round of review after these issues have been confirmed to be resolved, but I can't be of much help until then.

resetreboot · 2025-03-04T13:28:19Z

No problem @cr7pt0gr4ph7 just pushed (and verified as working) both volume and pitch faders with shift pressed (both weren't working when shift was pressed and the fix for both was the same and quick)

cr7pt0gr4ph7

LGTM with respect to the code itself. Can't test the functionality as I don't have the hardware, so someone else should retest.

m0dB · 2025-03-08T03:14:45Z

I will retest tomorrow. It would be great if we can also get this into 2.5.1. Once merged to main, could you create a PR for 2.5 as well? Same for the manual.

m0dB · 2025-03-09T17:35:04Z

A minor discrepancy between mapping and manual: in transport mode, slider range reset is pad 5, in the manual it's pad 8. Do you want me to correct the manual? (Including the svg)

m0dB · 2025-03-09T17:39:15Z

And another discrepancy: the values for Loop with shift are different than what the manual says.

m0dB · 2025-03-09T17:59:02Z

Assuming that in these cases the manual is wrong and the mapping is correct, everything works perfectly! Great job, @resetreboot, very much appreciated! IMO this can be merged but maybe we should first correct the manual? If you do the .rst, I will do the .svgs.

I tried to use the mapping with 2.5 but it doesn't work. I am pretty sure an earlier version did work, so I am not sure if this is expected. Is this something you want to address? It would be great to have this mapping included with 2.5.1!

m0dB · 2025-03-09T18:50:17Z

Hm, I just noticed that I get a ton of warnings on startup:

Details

warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:2397:19 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:2398:29 Variable "isArguments" is used before its declaration at 11256:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:2399:40 Variable "isBuffer" is used before its declaration at 11402:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:2400:51 Variable "isTypedArray" is used before its declaration at 12177:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:2522:7 Variable "baseEach" is used before its declaration at 2836:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:2648:19 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:2655:19 Variable "getTag" is used before its declaration at 6063:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:2658:13 Variable "isBuffer" is used before its declaration at 11402:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:2683:11 Variable "isSet" is used before its declaration at 12114:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:2691:11 Variable "isMap" is used before its declaration at 11791:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:2769:14 Variable "setTimeout" is used before its declaration at 6644:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:2884:33 Variable "computed" is used before its declaration at 2888:15.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:2886:37 Variable "computed" is used before its declaration at 2888:15.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3072:14 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3311:22 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3312:22 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3313:42 Variable "getTag" is used before its declaration at 6063:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3314:42 Variable "getTag" is used before its declaration at 6063:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3323:24 Variable "isBuffer" is used before its declaration at 11402:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3324:14 Variable "isBuffer" is used before its declaration at 11402:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3332:29 Variable "isTypedArray" is used before its declaration at 12177:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3363:37 Variable "getTag" is used before its declaration at 6063:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3455:37 Variable "getTag" is used before its declaration at 6063:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3487:16 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3668:21 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3669:32 Variable "isBuffer" is used before its declaration at 11402:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3670:44 Variable "isTypedArray" is used before its declaration at 12177:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3674:15 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3692:45 Variable "isArguments" is used before its declaration at 11256:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3694:15 Variable "isArguments" is used before its declaration at 11256:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3862:46 Variable "previous" is used before its declaration at 3863:15.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:3947:14 Variable "setToString" is used before its declaration at 6656:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:4209:37 Variable "seen" is used before its declaration at 4210:15.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:4248:11 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:4281:37 Variable "createSet" is used before its declaration at 5458:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:14158:14 Variable "upperFirst" is used before its declaration at 15190:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:10998:14 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:4475:11 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:4478:47 Variable "stringToPath" is used before its declaration at 6734:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:6922:24 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:4814:33 Variable "getSymbols" is used before its declaration at 6030:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:4826:33 Variable "getSymbolsIn" is used before its declaration at 6047:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:4839:20 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:5104:26 Variable "wrapper" is used before its declaration at 5105:17.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:5113:46 Variable "getData" is used before its declaration at 5893:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:5130:46 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:5420:9 Variable "setData" is used before its declaration at 6634:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:5471:19 Variable "getTag" is used before its declaration at 6063:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:5527:42 Variable "getData" is used before its declaration at 5893:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:5558:41 Variable "setData" is used before its declaration at 6634:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:9126:18 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:9171:18 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:5860:14 Variable "setToString" is used before its declaration at 6656:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:9340:18 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:9365:18 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:5871:43 Variable "getSymbols" is used before its declaration at 6030:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:5883:45 Variable "getSymbolsIn" is used before its declaration at 6047:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:6157:10 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:6157:29 Variable "isArguments" is used before its declaration at 11256:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:11483:32 Variable "isTypedArray" is used before its declaration at 12177:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:6267:14 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:6267:32 Variable "isArguments" is used before its declaration at 11256:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:6322:11 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:1858:19 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:1662:35 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:9552:18 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:6445:13 Variable "cache" is used before its declaration at 6451:11.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:6446:11 Variable "cache" is used before its declaration at 6451:11.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:9589:12 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:9593:12 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:9677:18 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:9706:18 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:9747:18 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:9766:18 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:9796:18 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:9816:18 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:9892:18 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:14862:20 Variable "attempt" is used before its declaration at 15245:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:8985:11 Variable "previous" is used before its declaration at 8989:13.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:1420:40 Variable "" is used before its declaration at 17081:7.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:1420:75 Variable "" is used before its declaration at 17081:7.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:10651:47 Variable "isArray" is used before its declaration at 11284:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:12836:20 Variable "mergeWith" is used before its declaration at 13470:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:14628:44 Variable "upperFirst" is used before its declaration at 15190:9.
warning [Controller] file:///Users/maarten/git/mixxx/res/controllers/lodash.mixxx.js:16991:30 Variable "chainAll" is used before its declaration at 16998:13.
warning [Controller] Lodash is deprecated and will be removed in a future release of Mixxx; refer to the page https://github.com/mixxxdj/mixxx/wiki/Lodash-Migration for migrations instructions
warning [Controller] ERROR! new Deck() called without specifying any deck numbers
warning [Controller] @file:///Users/maarten/git/mixxx/res/controllers/Hercules-DJControl-Inpulse-500-script.js:1003
warning [Controller] Too many arguments, ignoring 1
warning [Controller] @file:///Users/maarten/git/mixxx/res/controllers/Hercules-DJControl-Inpulse-500-script.js:1005
warning [Controller] Too many arguments, ignoring 1
warning [Controller] @file:///Users/maarten/git/mixxx/res/controllers/Hercules-DJControl-Inpulse-500-script.js:1007
warning [Controller] Too many arguments, ignoring 1
warning [Controller] @file:///Users/maarten/git/mixxx/res/controllers/Hercules-DJControl-Inpulse-500-script.js:1009
warning [Controller] Too many arguments, ignoring 1
warning [Controller] @file:///Users/maarten/git/mixxx/res/controllers/Hercules-DJControl-Inpulse-500-script.js:1019
warning [Controller] Too many arguments, ignoring 1
warning [Controller] @file:///Users/maarten/git/mixxx/res/controllers/Hercules-DJControl-Inpulse-500-script.js:1021
warning [Controller] Too many arguments, ignoring 1
warning [Controller] @file:///Users/maarten/git/mixxx/res/controllers/Hercules-DJControl-Inpulse-500-script.js:1023
warning [Controller] Too many arguments, ignoring 1
warning [Controller] @file:///Users/maarten/git/mixxx/res/controllers/Hercules-DJControl-Inpulse-500-script.js:1025
warning [Controller] Too many arguments, ignoring 1
warning [Controller] @file:///Users/maarten/git/mixxx/res/controllers/Hercules-DJControl-Inpulse-500-script.js:1033
warning [Controller] Too many arguments, ignoring 1
warning [Controller] @file:///Users/maarten/git/mixxx/res/controllers/Hercules-DJControl-Inpulse-500-script.js:1034
warning [Controller] Too many arguments, ignoring 1
warning [Controller] options.deck and option.group are both set; options.deck will take priority
warning [Controller] options.deck and option.group are both set; options.deck will take priority
warning [Controller] options.deck and option.group are both set; options.deck will take priority
warning [Controller] options.deck and option.group are both set; options.deck will take priority
warning [LibraryScanner 1] QSqlDatabasePrivate::removeDatabase: connection 'MIXXX-2' is still in use, all queries will cease to work.

resetreboot · 2025-03-09T23:36:12Z

That's strange, I'm on 2.5.0 and I've been rocking it no problem.

About the discrepancies, yeah, I think we need to fix the manual. Trust the code. I will take a look along the week. THank you for the extra testing!

m0dB · 2025-03-09T23:48:25Z

Ok, I will try again with 2.5 branch tomorrow.

The warning are with this branch too. You don’t get them?

resetreboot · 2025-03-09T23:49:48Z

I will take a look tomorrow, I have a session coming so they should pop out if they are there. I'm about to head to bed here.

m0dB · 2025-03-09T23:54:07Z

And a final note, in the Setting page it still has the 1d postfix in the name, and only list DJ Phatso as the author.

resetreboot · 2025-03-10T23:38:10Z

@m0dB I can confirm I have those messages about extra parameters. I will look at the docs of the Mixxx API to see how these callbacks have changed since 2.4 and adjust them so we have 0 warnings. Also, the lodash stuff is this code's fault? Because we aren't loading it anywhere.

resetreboot · 2025-03-12T00:42:38Z

Fixed the warnings and the author data, and version name.

m0dB · 2025-03-17T09:52:22Z

I tested on main and 2.5 and all good! Do you want me to create the MR for 2.5? I have a branch ready.

I see there is a eslint warning left. I see there is a comment to disable the check but apparently it doesn't work... No idea why. Can you try

var DJCi500 = {}; // eslint-disable-line

?

m0dB · 2025-03-17T18:38:39Z

I have created the PR for 2.5 here #14491

In that PR I changed the line

var DJCi500 = {};

to:

var DJCi500 = {}; // eslint-disable-line

in order to satisfy pre-commit.

m0dB · 2025-03-17T19:21:27Z

I created a PR with final fixes for manual to match the mapping in resetreboot/manual#3

resetreboot · 2025-03-18T14:03:55Z

Okay, that should be it, also thanks @m0dB for the PR for the 2.5 branch and the fixes to the manual, much appreciated.

Add Hercules DJControl Inpulse 500 mapping

fc04e79

github-actions Bot added the controller mappings label Feb 9, 2025

cr7pt0gr4ph7 suggested changes Feb 9, 2025

View reviewed changes

Comment thread res/controllers/Hercules_DJControl_Inpulse_500.midi.xml Outdated

resetreboot and others added 24 commits February 10, 2025 17:19

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

e236755

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

d022af7

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

267a72f

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

d4edbdd

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

e3fd7ef

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

b8c7b67

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

a21d10d

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

dbc5074

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

b6b100a

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

d5fa2c0

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

f04380d

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

008cbcd

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

68e2b92

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

a53db1c

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

fa36779

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

9e4febf

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

cbac34f

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

6dca6d2

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

e8b0480

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

70deb55

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

63d737e

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

bf792bb

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

c68b201

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

Update res/controllers/Hercules-DJControl-Inpulse-500-script.js

97d2855

Co-authored-by: Lukas Waslowski <cr7pt0gr4ph7@gmail.com>

cr7pt0gr4ph7 approved these changes Mar 4, 2025

View reviewed changes

fix: volume and pitch faders didn't work with shift

4ae96e7

resetreboot requested a review from cr7pt0gr4ph7 March 4, 2025 13:28

cr7pt0gr4ph7 approved these changes Mar 7, 2025

View reviewed changes

m0dB mentioned this pull request Mar 8, 2025

Changelog 2.5.1 #14446

Closed

resetreboot added 2 commits March 12, 2025 01:40

fix: warnings at startup, name and authors

f982436

fix: remove commented lodash loading

172e775

resetreboot requested a review from cr7pt0gr4ph7 March 12, 2025 00:42

m0dB mentioned this pull request Mar 17, 2025

Add Hercules DJControl Inpulse 500 mapping to 2.5 #14491

Merged

fix: fix linter

b162e0a

cr7pt0gr4ph7 approved these changes Mar 21, 2025

View reviewed changes

m0dB approved these changes Mar 21, 2025

View reviewed changes

m0dB merged commit 371d5f1 into mixxxdj:main Mar 21, 2025

ronso0 mentioned this pull request May 5, 2025

feat: HERCULES INPULSE 500 mappings #13054

Closed

Uh oh!

Conversation

resetreboot commented Feb 9, 2025 • edited by acolombier Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoergAtGithub commented Feb 9, 2025

Uh oh!

cr7pt0gr4ph7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cr7pt0gr4ph7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cr7pt0gr4ph7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cr7pt0gr4ph7 left a comment

Choose a reason for hiding this comment

Uh oh!

resetreboot commented Mar 4, 2025

Uh oh!

cr7pt0gr4ph7 left a comment

Choose a reason for hiding this comment

Uh oh!

m0dB commented Mar 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m0dB commented Mar 9, 2025

Uh oh!

m0dB commented Mar 9, 2025

Uh oh!

m0dB commented Mar 9, 2025

Uh oh!

m0dB commented Mar 9, 2025

Uh oh!

resetreboot commented Mar 9, 2025

Uh oh!

m0dB commented Mar 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

resetreboot commented Mar 9, 2025

Uh oh!

m0dB commented Mar 9, 2025

Uh oh!

resetreboot commented Mar 10, 2025

Uh oh!

resetreboot commented Mar 12, 2025

Uh oh!

m0dB commented Mar 17, 2025

Uh oh!

m0dB commented Mar 17, 2025

Uh oh!

m0dB commented Mar 17, 2025

Uh oh!

resetreboot commented Mar 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

resetreboot commented Feb 9, 2025 •

edited by acolombier

Loading

m0dB commented Mar 8, 2025 •

edited

Loading

m0dB commented Mar 9, 2025 •

edited

Loading

resetreboot commented Mar 18, 2025 •

edited

Loading