feat: HERCULES INPULSE 500 mappings

[jssotomdz]

included colored hotcues, slicer and beatmatch guides

[JoergAtGithub]

The pre-commit check is failing. The best way to fix pre-commit issues is to install pre-commit locally on your system, as described here: https://github.com/mixxxdj/mixxx/wiki/Using-Git#set-up-automatic-code-checking
Than it will fix these issues automatically before every commit.
Alternatively, you can download the pre-commit.patch file from the artifacts of this PR

unzip it, and apply it using:
git apply pre-commit.patch

[Holzhaus]

Thanks for contributing.

[alephlm]

Something on this files are not working for me, for example when I change songs in the deck, the hot cues LEDs are not changing for the new hotcues. Also when started, the volume of the deck is not in sync with UI until I start moving the slider. And slicer is just red color all LEDs but I do not get anything when pressed.
I am using the latest version of Mixxx just cloned and compiled it (Mixxx 2.6.0-alpha).

I would like to try to contribute, but I get lost on the sea of documentation and cant find what I really need. As a web developer I would expect the XML act as HTML and JS control its behaving.

But for example, in this code, inside init(). Where midi is coming from?
midi.sendShortMsg(0x91, 0x03, 0x7F);
what sendShortMsg does? Where can I check what other methods are available?

same questions for engine and its methods.
engine.makeConnection("[Channel1]", "play", channelLEDsCallback);

Thank you

[github-actions]

This PR is marked as stale because it has been open 90 days with no activity.

[kalsifer-742]

Does this means that i have to try the mapping myself and review it positively for it to be approved?
I own this controller, so I can do this if it's needed.

(I also wanted to contribute the mapping for this controller, so if I can help let me know)

[ronso0]

edit Thanks for offering your help @kalsifer-742 !

The Inpulse 500 mapping has been added recently: for main #14316, 2.5 backport is #14491

So I think we can close this.
I didn't look into the details, but it seems the merged mapping has the functions mentioned in the OP (colored hotcues, slicer and beatmatch guides)
If this mapping here has additional functions, I suggest someone picks it up and tries to move them into the official mapping.

[kalsifer-742]

@ronso0 thank you for the update!

I understand that this mapping is now included in Mixxx, correct?
Going forward if I want to improve the mapping, I have to create another pull request right?

(Also the wiki should be updated listing the controller as community supported and not in development)

[ronso0]

I understand that this mapping is now included in Mixxx, correct?

Yes, see https://github.com/mixxxdj/mixxx/tree/2.5/res/controllers

Going forward if I want to improve the mapping, I have to create another pull request right?

Exactly! Please create isolated PRs for bugfixes (if there are any) and new features.