Pitch/Tempo slider: set default range for clean profile#1230
Pitch/Tempo slider: set default range for clean profile#1230ronso0 wants to merge 4 commits intomixxxdj:masterfrom
Conversation
|
Isn't |
| m_pConfig->getValueString(ConfigKey("[Controls]", "RateRange")).length() == 0) { | ||
| int rateRangePercent = 8; | ||
| m_pConfig->set(ConfigKey("[Controls]", "RateRangePercent"), ConfigValue(rateRangePercent)); | ||
| slotSetRateRangePercent(rateRangePercent); |
There was a problem hiding this comment.
Isn't slotSetRateRangePercent called if you set the combobox to the new value?
Maybe you need to call it manually
That's what's happening here, isn't it?
I tested it, it works, so I assumed those lines are processed on startup.
Or do I get it wrong?
There was a problem hiding this comment.
I have not tested it. Is this
I don't know how to fix the other issue I noticed that defaults would be restored visually but not actually applied.
issue solved than?
There was a problem hiding this comment.
Nope!
As I reported, it affects other settings as well, i.e position display. Don't know how to approach that.
An explicite The confusing situation is probably that the RateRange is adopted immediately, does not require an apply. |
Appearantly, this would have to be done explicitly for all defaults then. I don't think slotResetToDefaults() is called when mixxx starts up with no mixxx.cfg, it appears initial defaults are set in initalization. It's again PositionDisplay where I noticed this: on fresh start its 'Elapsed' (here), when you click 'Restore defaults' it jumps to 'Remaining' (here) |
|
Yes, it looks like you found a bug nest ;-) |
Urgh... So I think I did what I can, the other stuff sounds like spanish to me and it would take me ages to fix it. |
|
I poked the bugs' nest and it got ugly... #1377 cleans up some of it. |
3 participants
Fixing Bug 1676140 Pitch/Tempo slider range default is 0%.
This sets rate range to 8%.
I don't know how to fix the other issue I noticed that defaults would be restored visually but not actually applied.