fix for BPM becoming Inf (https://bugs.launchpad.net/mixxx/+bug/1631393)#1206
Merged
daschuer merged 1 commit intomixxxdj:masterfrom Jul 8, 2017
meschi:master
Merged
fix for BPM becoming Inf (https://bugs.launchpad.net/mixxx/+bug/1631393)#1206daschuer merged 1 commit intomixxxdj:masterfrom meschi:master
daschuer merged 1 commit intomixxxdj:masterfrom
meschi:master
Conversation
raterange was 0 and unchecked, resulted in division through zero.
Member
|
Thank you for the pull request. It looks good to me. |
Member
|
@meschi did you sign the agreement? Than I can merge this. |
Contributor
|
Hi @meschi, have you signed the contributor agreement? It just gives us permission to distribute your code under the GPL v2 with an exception to also publish it in the Mac App Store. |
Contributor
|
The larger issue of the rate range being set to 0 with a fresh config file is being addressed in PR #1230. |
Contributor
Author
|
Sorry it took a while. Signed the contributors agreement (Kilian Feess). |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m_pRateRange->get() is zero and not checked.
This results in division through zero. This change checks if the rateRange is zero and sets the pitch change accordingly.
This PR fixes a filed bug for the 2.1.0 release.
https://bugs.launchpad.net/mixxx/+bug/1631393
I don't know why the range is zero. On a fresh startup the config file is created with the value 8, but the value is not used on the first start. With this fix the value is read on the second startup after being shut down gracefully. Without the fix neither the config file not the analyzed songs are written to disk. I think fixing the loading of th config-file belongs to another pull request.