Skip to content

Kontrol S4 Mk3: add documentation for the device#550

Merged
JoergAtGithub merged 2 commits into
mixxxdj:2.4from
acolombier:feat/ni-traktor-s4mk3-mapping
Jun 4, 2023
Merged

Kontrol S4 Mk3: add documentation for the device#550
JoergAtGithub merged 2 commits into
mixxxdj:2.4from
acolombier:feat/ni-traktor-s4mk3-mapping

Conversation

@acolombier
Copy link
Copy Markdown
Member

@acolombier acolombier commented Feb 22, 2023

This PR is the documentation for that PR.

@acolombier acolombier force-pushed the feat/ni-traktor-s4mk3-mapping branch from 4bcf83c to d520ba5 Compare February 22, 2023 19:22
@acolombier acolombier mentioned this pull request Feb 22, 2023
Merged
@acolombier acolombier force-pushed the feat/ni-traktor-s4mk3-mapping branch from d520ba5 to 7f44b2f Compare February 22, 2023 20:58
@uklotzde
Copy link
Copy Markdown
Contributor

uklotzde commented Feb 22, 2023

@Swiftb0y @ronso0 @daschuer @JoergAtGithub What happened to the deploy previews of PRs? Not available due to unrelated link check failures?

@ronso0
Copy link
Copy Markdown
Member

ronso0 commented Feb 22, 2023

@Holzhaus may know, I don't 🤷‍♂️

@uklotzde
Copy link
Copy Markdown
Contributor

uklotzde commented Feb 22, 2023

The link checks are meaningless and only an obstacle if no one ever fixes them.

@JoergAtGithub
Copy link
Copy Markdown
Member

JoergAtGithub commented Feb 22, 2023

The link checks are unrelated to the Netlify Preview. Stanton relaunced their website yesterday and now the links to former products are broken.
But other builds with the same Link Check failures have Netlify Previews, see: #484

@ronso0
Copy link
Copy Markdown
Member

ronso0 commented Feb 22, 2023

#484 is for 2.3, but netlify seems to fail for 2.4 PRs like this and #533

@acolombier acolombier force-pushed the feat/ni-traktor-s4mk3-mapping branch from 7f44b2f to 501d897 Compare March 9, 2023 20:18
@JoergAtGithub
Copy link
Copy Markdown
Member

JoergAtGithub commented Apr 2, 2023

Could you please merge upstream/2.4. This should fix the CI fails and generate the preview.

@acolombier acolombier force-pushed the feat/ni-traktor-s4mk3-mapping branch 2 times, most recently from 0bd30d3 to b1edca1 Compare April 2, 2023 14:35
@acolombier
Copy link
Copy Markdown
Member Author

acolombier commented Apr 2, 2023

Looks like forum.djtechtools.com is experiencing some issue. Probably will need to retry the GH actions when the outage is fixed.

@JoergAtGithub
Copy link
Copy Markdown
Member

JoergAtGithub commented Apr 6, 2023

Could you merge upstream/2.4 again,

@Holzhaus
Copy link
Copy Markdown
Member

Holzhaus commented Apr 9, 2023

@Swiftb0y @ronso0 @daschuer @JoergAtGithub What happened to the deploy previews of PRs? Not available due to unrelated link check failures?

No, this is not the reason. Deploy previews are only added for PRs where the target branch is in the deploy branch list. Deploy branches are branches that trigger a redeploy of the site on changes. Currently, the deploy branches are main, 2.2 and 2.3. Someone added a 2.4 branch to the repo without also adding it to the deploy branch list. I added 2.4 and 2.5 now.

@JoergAtGithub
Copy link
Copy Markdown
Member

JoergAtGithub commented Apr 27, 2023

Could you please commit a dummy change to trigger the Preview generation.

@acolombier acolombier force-pushed the feat/ni-traktor-s4mk3-mapping branch from b1edca1 to 267e752 Compare April 30, 2023 19:07
@Swiftb0y
Copy link
Copy Markdown
Member

Swiftb0y commented Apr 30, 2023

The failing deploy preview seems like an issue on our end.

9:07:44 PM: Theme error:
9:07:44 PM: An error happened in rendering the page 404.
9:07:44 PM: Reason: UndefinedError("'style' is undefined")

JoergAtGithub
JoergAtGithub requested changes May 27, 2023
View reviewed changes
Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst Outdated
Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst Outdated
Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst Outdated
Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst Outdated
Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst Outdated
Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst Outdated
Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst Outdated
Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst Outdated
Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst Outdated

.. _the Mixxx control documentation: https://manual.mixxx.org/2.4/en/chapters/appendix/mixxx_controls.html#control-[Library]-sort_column

This settings are only useful if you are using Haptic Drive features
Copy link
Copy Markdown
Member

@JoergAtGithub JoergAtGithub May 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haptic Drive is a Trademark - I'm not sure if we may use it in this sense

Copy link
Copy Markdown
Member Author

@acolombier acolombier Jun 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to reformulate this to use haptic feedback instead in the manual and have added a little bit more details in the limitation section you've requested above

Comment thread source/hardware/controllers/native_instruments_traktor_kontrol_s4_mk3.rst Outdated
@acolombier acolombier force-pushed the feat/ni-traktor-s4mk3-mapping branch from db64868 to 3b941b0 Compare June 3, 2023 19:45
@JoergAtGithub
Copy link
Copy Markdown
Member

JoergAtGithub commented Jun 3, 2023

The pre-commit fails needs to be addressed, the other CI fails are unrelated.

@acolombier acolombier force-pushed the feat/ni-traktor-s4mk3-mapping branch from 3b941b0 to 1d4fa5a Compare June 3, 2023 20:05
@ronso0 ronso0 removed their request for review June 3, 2023 22:43
@JoergAtGithub
Copy link
Copy Markdown
Member

JoergAtGithub commented Jun 4, 2023

LGTM! Thank you!
CI failures are unrelated!

@JoergAtGithub JoergAtGithub merged commit 0661126 into mixxxdj:2.4 Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronso0 ronso0 ronso0 left review comments

@JoergAtGithub JoergAtGithub JoergAtGithub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@acolombier @uklotzde @ronso0 @JoergAtGithub @Holzhaus @Swiftb0y