Update denon_mc7000.rst#484
Conversation
|
This update belongs to mixxxdj/mixxx#4729 |
| ----------------------- | ||
|
|
||
| 8 samplers can be triggered from either Deck. | ||
| 8 samplers can be triggered from each Deck if MC7000.SamplerQty is set to 32. Deck 1 will play sampler 1 to 8, Deck 2 will play sampler 9 to 16, Deck 3 will play sampler 17 to 24 and Deck 4 will play sampler 25 to 32. |
There was a problem hiding this comment.
Most users will simply use the default mapping without any customization. The manual should primarily describe this and simply refer to the script if users intend to customize it.
As a regular user without any ambitions to program JavaScript I find the references to internals of the script more confusing than helpful.
TL;DR IMHO it would be sufficient to describe only the default behavior in the manual and document the options for customization in the script code.
There was a problem hiding this comment.
I set the default to 16 samplers in the script now, so the user does not need to take any action before using, this works with the default skin.
There was a problem hiding this comment.
comment for 32 samplers is now in the script code.
| Apart from that the behavior is equal to Sampler Mode. | ||
|
|
||
| 8 samplers can be triggered from each Deck if MC7000.SamplerQty is set to 32. Deck 1 will play sampler 1 to 8, Deck 2 will play sampler 9 to 16, Deck 3 will play sampler 17 to 24 and Deck 4 will play sampler 25 to 32. | ||
| If MC7000.SamplerQty is set to 16, Deck 1 and Deck 3 will play the samplers 1 to 8 and Deck 2 and Deck 4 will play the samplers 9 to 16. |
There was a problem hiding this comment.
I suggest to omit the description of the non-default behavior from the manual.
There was a problem hiding this comment.
16 samplers will be the standard and therefore all 32 sampler information be removed from the manual.
uklotzde
left a comment
uklotzde
left a comment
There was a problem hiding this comment.
I just left some thoughts about the intended audience of the manual. The existing MC 7000 page is overambitious in this respect and confuses regular users with extra information that is useless for them. Isolating the developer documentation in .. hint:: sections seems reasonable. Sometimes it is not clear what the default setting actually is if I select the controller in the preferences, knowing absolutely nothing about mapping scripts.
The SVG illustrations as a bonus are nice.
|
Please check the failing pre-commit action that complains about some formatting issues. The failing link checks are probably unrelated, ignore them. |
|
Thank you so far uklotzde, |
|
that serato flip logo might be trademarked. I think we should remove it just in case. |
|
Just a hint: |
|
Thanks Ronso, |
|
Pre-Commit is broken now. You can fix this by using |
uploaded new files. |
|
before I uploaded the files, the background was set to ff (white), after applying the pre-commit patch file it is back to 00. So there is still the dark theme problem. Any ideas how to solve this? |
|
could you please attach an example SVG (before) that got reverted by pre-commit? |
|
found a solution, will update again. |
|
I don't see a white background in that image. At least not in the num pad rows |
|
I think we should squash all commits when you're done. There's a lot of back and forth it seems. |
|
on my browser with dark theme it looks like this: |
|
I don't know which svg editor you used, but if I download that file you posted last and put a gradient in the layer below it look s like this: |
|
The file used was already outdated by the time you used it, therefore I deleted the post. In the beginning I modified the files using inkscape, all later versions where I posted that I found a solution were modified using a text editor. |
|
I checked the netlify preview and set a dark background. Graphics look good now, thanks. I just noticed the controller overvew could be cropped, don't know if you like to squeeze that in as well |
|
@holopansel Do you work with git locally or with the Github web interface? |
JoergAtGithub
left a comment
JoergAtGithub
left a comment
There was a problem hiding this comment.
The added documentation of the new features itself is correct!
|
The many commits result from using the web interface. |
|
@JoergAtGithub If you agree I'd squash this into 2-3 commits and push to @holopansel's repo? |
|
Yes, I agree! |
|
would also be ok for me. |
| .. hint:: | ||
| To use default Mixxx behaviour and allow playing multiple samplers at the same time you can set the user variable ``MC7000.prevSamplerStop`` inside the :ref:`JavaScript file<denon_mc7000_uservariables>` to ``false``. | ||
|
|
||
| Pitch Mode (green LED) |
There was a problem hiding this comment.
| Pitch Mode (green LED) | |
| Pitch Play Mode (green LED) |
I'll fix it.
|
@JoergAtGithub wanna take a final look before merge? |
|
LGTM! |
|
Thank you! |
|
Thank you all. |
5 participants
I also created the two new svg files already linked in the document
.