Document the Traktor Kontrol S3 FX changes#533
Conversation
|
By the way, both of these PRs assume mixxxdj/mixxx#11198 has been merged. If that situation changes or if mixxxdj/mixxx#4687 can do the trick instead (it did not yet work when I tried it) then this and the comments in the script need to be amended. |
Yeah. Linking to a forum thread would be okay I'd say. |
|
after 2.3 has been merged into 2.4 pre-commit should work again. |
|
Could you please merge upstream/2.4. This should fix the CI fails and generate the preview. |
robbert-vdh
force-pushed
the
feature/traktor-kontrol-s3-script-improvements
branch
from
3b8eade to
4874ae1
Compare
|
Done. Sorry it took so long, had a busy couple weeks! |
|
Broken links come from www.keithmcmillen.com |
|
Could you please commit a dummy change to trigger the Preview generation. |
robbert-vdh
force-pushed
the
feature/traktor-kontrol-s3-script-improvements
branch
from
4874ae1 to
06c0aaf
Compare
|
@JoergAtGithub I rebased on top of the new 2.4 branch. |
|
Deploy failed because the nodejs download servers 500'd. The retried build unfortunately doesn't show up in the github UI. The deploy preview for 06c0aaf can be found at https://644c0b2ed647ff00b334cb21--mixxx-manual.netlify.app/ |
|
Could you please merge upstream/2.4 to fix the CI fails. |
|
@robbert-vdh I talked to @ywwg and we think the mapping PR mixxxdj/mixxx#11199 can be merged as it is, without waiting for mixxxdj/mixxx#11198. |
|
Should I then document the soft takeover behavior instead? Because soft takeover can be pretty confusing if you're expecting similar behavior to Pioneer/Denon/Traktor/Serato/most other DJ software. |
|
The documentation must match, what we get, when we only merge the mapping PR. But you don't need to to write down so many details in the mapping documentation. |
And document the soft takeover behavior instead.
robbert-vdh
force-pushed
the
feature/traktor-kontrol-s3-script-improvements
branch
from
06c0aaf to
2f60032
Compare
|
I removed the reference to the superknob adoption and I replaced it with a bit describing the soft takeover behavior. |
|
LGTM! Thank you! |
4 participants
These are the manual changes accompanying mixxxdj/mixxx#11199. I split up the effects section to cover both modes, and I've moved the FX knob behavior for 'filter mode' to the new Multi Effect mode sections. I went with Quick Effect Mode and Multi Effect Mode for the time being because naming things is difficult!
It might also be nice to link to some suitable quick effect chain presets on the manual page.