refactor: PackedHoge型をPacked<'Hoge'>型に書き換える #7792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
done |
これについては各Packedを普通にmisskey.jsみたいに型定義すれば解決しそう |
|
(でもOpenAPIのスキーマと二重に定義するのも微妙か) |
二重にするとどっちかがアップデートされないとかがあり得るので（特にMisskeyは…）これはやりたくない |
syuilo
reviewed
Sep 18, 2021
src/services/note/read.ts
Outdated
| @@ -52,7 +52,7 @@ export default async function( | |||
|
|
|||
| if (note.user != null) { // たぶんnullになることは無いはずだけど一応 | |||
| for (const antenna of myAntennas) { | |||
| if (checkHitAntenna(antenna, note, note.user as any, undefined, Array.from(following))) { | |||
| if (await checkHitAntenna(antenna, note, note.user as any, undefined, Array.from(following))) { | |||
syuilo
reviewed
Sep 18, 2021
| const matching = typeof src === 'object' ? src : await this.findOneOrFail(src); | ||
|
|
||
| return await awaitAll({ | ||
| id: matching.id, | ||
| createdAt: matching.createdAt, | ||
| createdAt: matching.createdAt.toISOString(), |
There was a problem hiding this comment.
バグ修正というよりは型定義に合わせた感じ？
|
リファクタ以外の変更も色々入ってそうだけど、バグ修正という認識でいいんかな |
|
かも？ |
|
コンフリクトしてたので解消した |
|
🙏 |
snk-lab
pushed a commit
to snk-lab/misskey-kusa-note
that referenced
this pull request
Sep 24, 2021
* packedNotificationSchemaを更新 * read:gallery, write:gallery, read:gallery-likes, write:gallery-likesに翻訳を追加 * fix * add header, choice, invitation * test * fix * yatta * remove no longer needed "as PackedUser/PackedNote" * clean up * add simple-schema * fix lint * define items in full Schema * revert misskey-dev#7772 (comment) * user packとnote packの型不整合を修正 * add prelude/types.ts * emoji * signin * game * matching * fix * add emoji schema * add reversiGame * add reversiMatching * remove signin schema (use Signin entity) * add Packed type * note-reaction * user * user-group * user-list * note * app, messaging-message * notification * drive-file * drive-folder * following * muting * blocking * hashtag * page * app (with modifying schema) * import user? * channel * antenna * clip * gallery-post * emoji * Packed * reversi-matching * add changelog * add changelog * revert fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spin off of #7769
Required PR
#7789
What
misc/schema.tsでPacked型を実装し、従来repositoryファイルで定義していたpackedHogeをPacked<'Hoge'>と置き換えます。
Why
VS Code上で変数をホバーして型を見ようとするとき、PackedHogeのままだと意味不明な表示がされるが、
Packed<'Hoge'>とジェネリクス型にするとPacked<'Hoge'>と表示されるので、見易くなる。全て書き換えるメリットとして、
type PackedHoge = Packed<'Hoge'>;と定義しなおしてPackedHogeを外部から参照するより、直接Packed型を参照すればスマートだと思う