refactor: スキーマのないpack関数にスキーマを定義 #7789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamaina
changed the title
数少ないしスキーマ定義する方向にしていい？ @syuilo |
良さそう |
tamaina
changed the title
|
やった SigninはSigninエンティティ直接指定でよくねってことにした |
|
Included in #7792 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spin off of #7769
What
pack関数があってストリームで利用されているにもかかわらずPackedオブジェクト型が提供されていないものについて、とりあえず関数の実装から推測するように。
（本当はスキーマを定義したほうがいいのかも）
Why
any撲滅委員会