refactor: Expand schema #7772
Merged
refactor: Expand schema #7772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
テストが通らなくなったけどエラーコードを読み解けなかった |
|
misc/schema.tsでTypeORMをロードする前に呼んでいるのが原因のような気がする しかし実働環境だとエラー出てないのでなんだかなぁ |
|
TypeORMを読み込まないシンプルなスキーマインターフェースを定義した |
|
コンフリクト解消した |
|
userとnoteの型エラー気になるから直していいかしら |
syuilo
reviewed
Sep 11, 2021
syuilo
reviewed
Sep 11, 2021
| @@ -43,7 +43,7 @@ export default class extends Channel { | |||
|
|
|||
| // 関係ない返信は除外 | |||
| if (note.reply) { | |||
| const reply = note.reply as PackedNote; | |||
| const reply = note.reply; | |||
There was a problem hiding this comment.
こういう型注釈消してる変更は、refが展開されるようになったから不要になったってことかな
tamaina
added a commit
to tamaina/misskey
that referenced
this pull request
Sep 11, 2021
直してみた |
|
YOSASOU |
|
テスト確認したらマージする |
|
👍👍👍 |
syuilo
pushed a commit
that referenced
this pull request
Sep 22, 2021
* packedNotificationSchemaを更新 * read:gallery, write:gallery, read:gallery-likes, write:gallery-likesに翻訳を追加 * fix * add header, choice, invitation * test * fix * yatta * remove no longer needed "as PackedUser/PackedNote" * clean up * add simple-schema * fix lint * define items in full Schema * revert #7772 (comment) * user packとnote packの型不整合を修正 * add prelude/types.ts * emoji * signin * game * matching * fix * add emoji schema * add reversiGame * add reversiMatching * remove signin schema (use Signin entity) * add Packed type * note-reaction * user * user-group * user-list * note * app, messaging-message * notification * drive-file * drive-folder * following * muting * blocking * hashtag * page * app (with modifying schema) * import user? * channel * antenna * clip * gallery-post * emoji * Packed * reversi-matching * add changelog * add changelog * revert fix
snk-lab
pushed a commit
to snk-lab/misskey-kusa-note
that referenced
this pull request
Sep 24, 2021
* packedNotificationSchemaを更新 * read:gallery, write:gallery, read:gallery-likes, write:gallery-likesに翻訳を追加 * fix * add header, choice, invitation * test * fix * yatta * remove no longer needed "as PackedUser/PackedNote" * clean up * add simple-schema * fix lint * define items in full Schema * revert misskey-dev#7772 (comment) * user packとnote packの型不整合を修正
snk-lab
pushed a commit
to snk-lab/misskey-kusa-note
that referenced
this pull request
Sep 24, 2021
* packedNotificationSchemaを更新 * read:gallery, write:gallery, read:gallery-likes, write:gallery-likesに翻訳を追加 * fix * add header, choice, invitation * test * fix * yatta * remove no longer needed "as PackedUser/PackedNote" * clean up * add simple-schema * fix lint * define items in full Schema * revert misskey-dev#7772 (comment) * user packとnote packの型不整合を修正 * add prelude/types.ts * emoji * signin * game * matching * fix * add emoji schema * add reversiGame * add reversiMatching * remove signin schema (use Signin entity) * add Packed type * note-reaction * user * user-group * user-list * note * app, messaging-message * notification * drive-file * drive-folder * following * muting * blocking * hashtag * page * app (with modifying schema) * import user? * channel * antenna * clip * gallery-post * emoji * Packed * reversi-matching * add changelog * add changelog * revert fix
syuilo
pushed a commit
that referenced
this pull request
Oct 20, 2021
* wip * wip * wip * ✌️ * add main stream * packedNotificationSchemaを更新 * read:gallery, write:gallery, read:gallery-likes, write:gallery-likesに翻訳を追加 * fix * ok * add header, choice, invitation * add header, choice, invitation * test * fix * fix * yatta * remove no longer needed "as PackedUser/PackedNote" * clean up * add simple-schema * fix lint * fix lint * wip * wip! * wip * fix * wip * wip * ✌️ * 送信側に型エラーがないことを3回確認した * ✌️ * wip * update typescript * define items in full Schema * edit comment * edit comment * edit comment * Update src/prelude/types.ts Co-authored-by: Acid Chicken (硫酸鶏) <[email protected]> * #7769 (comment) * user packとnote packの型不整合を修正 * revert #7772 (comment) * revert #7772 (comment) * user packとnote packの型不整合を修正 * add prelude/types.ts * emoji * signin * game * matching * clean up * ev => data * refactor * clean up * add type * antenna * channel * fix * add Packed type * add PackedRef * fix lint * add emoji schema * add reversiGame * add reversiMatching * remove signin schema (use Signin entity) * add schemas refs, fix Packed type * wip PackedHoge => Packed<'Hoge'> * add Packed type * note-reaction * user * user-group * user-list * note * app, messaging-message * notification * drive-file * drive-folder * following * muting * blocking * hashtag * page * app (with modifying schema) * import user? * channel * antenna * clip * gallery-post * emoji * Packed * reversi-matching * update stream.ts * #7769 (comment) * fix lint * clean up? * add changelog * add changelog * add changelog * fix: アンテナが既読にならないのを修正 * revert fix * #7769 (comment) * spec => payload * edit commetn Co-authored-by: Acid Chicken (硫酸鶏) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spin off of #7769
Required PR
#7771
What
スキーマは、api-doc(Open Api)においてはobjectのrefが展開（リストからスキーマを取ってきて付け足す）されるが、Misskeyサーバーコード内のTypeScript Typeは展開されることなくunknownになっている。
SchemaをTypeへと変換するSchemaTypeタイプに手を加え、ref参照になっているオブジェクト指定についてpacked型定義を適切に付与する。
Why
#7769 の範囲内での型エラー撲滅。Misskeyサーバー開発をやりやすくする。