Skip to content

enhance: use scan mode for like although inverted index exists#41325

Merged
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
zhagnlu:skip_inverted_master
May 9, 2025
Merged

enhance: use scan mode for like although inverted index exists#41325
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
zhagnlu:skip_inverted_master

Conversation

@zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Apr 15, 2025

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Apr 15, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 15, 2025
@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2025

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2025

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

sre-ci-robot pushed a commit that referenced this pull request Apr 16, 2025
pr: #41325

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
liliu-z pushed a commit that referenced this pull request Apr 16, 2025
pr: #41325

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
@zhagnlu zhagnlu force-pushed the skip_inverted_master branch from 700cd27 to 7e204f3 Compare May 8, 2025 06:43
@mergify
Copy link
Contributor

mergify bot commented May 8, 2025

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 8, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 8, 2025

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@zhagnlu zhagnlu force-pushed the skip_inverted_master branch from 7e204f3 to 6fc0838 Compare May 8, 2025 09:04
@mergify
Copy link
Contributor

mergify bot commented May 8, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.48%. Comparing base (39e7ad3) to head (3c5791e).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/exec/expression/UnaryExpr.cpp 54.54% 5 Missing ⚠️
internal/core/src/index/HybridScalarIndex.h 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41325      +/-   ##
==========================================
- Coverage   80.53%   80.48%   -0.06%     
==========================================
  Files        1514     1515       +1     
  Lines      213685   214013     +328     
==========================================
+ Hits       172101   172252     +151     
- Misses      35405    35580     +175     
- Partials     6179     6181       +2     
Components Coverage Δ
Client 79.38% <ø> (ø)
Core 73.66% <70.83%> (-0.06%) ⬇️
Go 81.85% <ø> (-0.06%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/exec/expression/Expr.h 67.74% <100.00%> (-0.07%) ⬇️
internal/core/src/index/InvertedIndexTantivy.h 51.72% <100.00%> (-19.71%) ⬇️
internal/core/src/index/ScalarIndex.h 31.11% <100.00%> (+3.20%) ⬆️
internal/core/src/index/HybridScalarIndex.h 37.20% <0.00%> (-1.82%) ⬇️
internal/core/src/exec/expression/UnaryExpr.cpp 82.38% <54.54%> (-0.52%) ⬇️

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…s-io#41309)

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
@zhagnlu zhagnlu force-pushed the skip_inverted_master branch from 6fc0838 to 3c5791e Compare May 8, 2025 12:37
@mergify mergify bot added the ci-passed label May 8, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Collaborator

czs007 commented May 9, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit e3c81ba into milvus-io:master May 9, 2025
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants