Skip to content

enhance: use scan mode for like although inverted index exists#41309

Merged
sre-ci-robot merged 1 commit intomilvus-io:2.5from
zhagnlu:skip_inverted
Apr 15, 2025
Merged

enhance: use scan mode for like although inverted index exists#41309
sre-ci-robot merged 1 commit intomilvus-io:2.5from
zhagnlu:skip_inverted

Conversation

@zhagnlu
Copy link
Copy Markdown
Contributor

@zhagnlu zhagnlu commented Apr 15, 2025

pr: #41325

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Apr 15, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 15, 2025

@zhagnlu Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added dco-passed DCO check passed. do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Apr 15, 2025
@sunby
Copy link
Copy Markdown
Contributor

sunby commented Apr 15, 2025

we also need to fallback to scan for json index (CanUseIndexForJson in UnaryExpr.cpp)

@zhagnlu
Copy link
Copy Markdown
Contributor Author

zhagnlu commented Apr 15, 2025

we also need to fallback to scan for json index (CanUseIndexForJson in UnaryExpr.cpp)

good catch

@sunby sunby added this to the 2.5.10 milestone Apr 15, 2025
@zhagnlu zhagnlu force-pushed the skip_inverted branch 2 times, most recently from a43ebbf to 622334c Compare April 15, 2025 08:02
Signed-off-by: luzhang <luzhang@zilliz.com>
Copy link
Copy Markdown
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.88%. Comparing base (04eae0b) to head (b0fc08f).
Report is 3 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/core/src/exec/expression/UnaryExpr.cpp 90.90% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #41309      +/-   ##
==========================================
+ Coverage   80.86%   80.88%   +0.01%     
==========================================
  Files        1421     1421              
  Lines      203197   203209      +12     
==========================================
+ Hits       164321   164361      +40     
+ Misses      33120    33102      -18     
+ Partials     5756     5746      -10     
Components Coverage Δ
Client 79.65% <ø> (ø)
Core 70.65% <95.00%> (-0.04%) ⬇️
Go 82.77% <ø> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/exec/expression/Expr.h 63.78% <100.00%> (ø)
internal/core/src/index/InvertedIndexTantivy.h 51.72% <100.00%> (-19.71%) ⬇️
internal/core/src/index/ScalarIndex.h 31.11% <100.00%> (+3.20%) ⬆️
internal/core/src/exec/expression/UnaryExpr.cpp 83.85% <90.90%> (+0.04%) ⬆️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liliu-z liliu-z added ci-passed manual-pass manually set pass before ci-passed labeled labels Apr 15, 2025
@sre-ci-robot sre-ci-robot merged commit 2aae9ca into milvus-io:2.5 Apr 15, 2025
18 of 20 checks passed
liliu-z pushed a commit that referenced this pull request Apr 16, 2025
#41065

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
zhagnlu added a commit to zhagnlu/milvus that referenced this pull request May 8, 2025
…s-io#41309)

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
zhagnlu added a commit to zhagnlu/milvus that referenced this pull request May 8, 2025
…s-io#41309)

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
zhagnlu added a commit to zhagnlu/milvus that referenced this pull request May 8, 2025
…s-io#41309)

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants