Skip to content

fix:fix skip autoindex like expr#41330

Merged
sre-ci-robot merged 1 commit intomilvus-io:2.5from
zhagnlu:skip_autoindex_like_2.5
Apr 16, 2025
Merged

fix:fix skip autoindex like expr#41330
sre-ci-robot merged 1 commit intomilvus-io:2.5from
zhagnlu:skip_autoindex_like_2.5

Conversation

@zhagnlu
Copy link
Contributor

@zhagnlu zhagnlu commented Apr 15, 2025

pr: #41325

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 15, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Apr 15, 2025
@zhagnlu zhagnlu added this to the 2.5.10 milestone Apr 15, 2025
Signed-off-by: luzhang <luzhang@zilliz.com>
@zhagnlu zhagnlu force-pushed the skip_autoindex_like_2.5 branch from f953f32 to 9a4109f Compare April 15, 2025 12:00
@codecov
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.86%. Comparing base (55b37c3) to head (9a4109f).
Report is 2 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/core/src/index/HybridScalarIndex.h 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #41330      +/-   ##
==========================================
- Coverage   80.86%   80.86%   -0.01%     
==========================================
  Files        1421     1421              
  Lines      203211   203213       +2     
==========================================
  Hits       164332   164332              
- Misses      33120    33129       +9     
+ Partials     5759     5752       -7     
Components Coverage Δ
Client 79.65% <ø> (ø)
Core 70.64% <0.00%> (-0.01%) ⬇️
Go 82.75% <ø> (ø)
Files with missing lines Coverage Δ
internal/core/src/index/HybridScalarIndex.h 37.20% <0.00%> (-1.82%) ⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Apr 15, 2025
Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ebe1b1c into milvus-io:2.5 Apr 16, 2025
23 of 25 checks passed
liliu-z pushed a commit that referenced this pull request Apr 16, 2025
pr: #41325

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants