-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge v4 to mgt-chat #3026
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#2865) adds method to clear selected item from teams channel picker elements adds a story using selectionChanged event to show how clearSelectedItem can be uses
this ensures that keystrokes which might trigger in pages shortcuts in SharePoint don't reach those event listener and break the component experience
refactor the filtering of data for display inside a getter that filtered the fetched data based on the current state of the component filtering happens on render now Co-authored-by: Nickii Miaro <[email protected]>
add edit todo functionality rewrite edit option to apply focus on input element, remove the fluent-checkbox wrapper on todo tasks, fix @keydown function, add Radio svg to fix incomplete checkbox fix dot icon, fix title display add edit date funtionality --------- Co-authored-by: Gavin Barron <[email protected]> Co-authored-by: Musale Martin <[email protected]>
renames component to better suit current usage removes dead code calling deprecated Graph APIs for Outlook Tasks moves a number of strings into the localizable string collection for the component updates the generate script for mgt-react to clean files at the start of generation BREAKING CHANGE: mgt-tasks has been removed and replaced with mgt-planner. mgt-planner does not support data-source switching to fetch data from the outlook tasks apis any longer.
Add custom avatar size tokens for components building from mgt-person Add login person custom avatar-size token Update css props in login, people and people-picker Add default values to css tokens Update JSDoc comments for person card with section css customization tokens
uses a post build script to rewrite the index.html file and inject a CSP meta tag
) fix bug in changing mgt-person attributes --------- Co-authored-by: Sébastien Levert <[email protected]>
fix: revert csp tag in developer index.html (#2910)
Promoting Search to GA Updated stories for GA --------- Co-authored-by: Gavin Barron <[email protected]>
allows the input to expand to show a larger placeholder adds a story for the placeholder attribute
* feat: add ElectronContextBridgeProvider * fix: missing export for ElectronContextBridgeProvider --------- Co-authored-by: Gavin Barron <[email protected]>
Adds helpers to determine if current token has a required scope Adds helper to calculate the minimum scope to be requested if necessary Fix test for prepScopes to match new behavior BREAKING CHANGE: prepScopes now accepts an array of scopes, this is checked against the set of currently consented scopes for the user. If any of the supplied scopes are found, then no additional scopes are requested. If no match is found then the user will be prompted to consent to the first scope in the supplied array of scopes fix: getGroupImage now correctly requires group.read.all or group.readwrite.all BREAKING CHANGE: applications using mgt-person with fetch-image and person-detal where the supplied value is a group will now need to consent to either Group.Read.All or Group.ReadWrite.All. This replaces the existing behavior where the group image would silently fail to load and show an http 403 error in the console fix: updated todo and planner permissions BREAKING CHANGE: minimal permission for planner calls changed from Group.ReadWrite.All to Tasks.ReadWrite for write operation and from Group.Read.All to Tasks.Read for read operations
Co-authored-by: Sébastien Levert <[email protected]>
updated the keydown for the people-picker behavior to ensure that tab and enter can be used to enter email addresses when the allow-any-email attribute is present
Updating overview table with latest components Updating overview table Linking to stories in overview
…2920) Adding headers + count on requests when userFilters are present
* fix: remove readonly props from react components React components were incorrectly exposing readonly properties as setable via Props This change updates the generation script to correctly handle readonly properties The generation script now handles empty propTypes and import collections Empty prop types are not exported
removes the PersonViewType enum in favor of the ViewType enum BREAKING CHANGE: PersonViewType has been removed. 'avatar' is no longer a valid value for the 'view' attribute on the 'mgt-person' component
also removes a couple of dead code paths and refactors for easier reading
adds alerts to make button click actions apparent in mgt-get refresh story Closes #2349
Established pattern for using `@lit/tasks` in components with two new base classes; MgtBaseTaskComponent and MgtTemplatedTaskComponent. Converts existing component to use new base classes. Deprecates the MgtBaseComponent and MgtTemplatedComponent classes. The dataChanged event from mgt-get now bubbles and is composed MgtBaseTaskComponent supplies providerState as a reactive property in the default set of args to be watched Fixes an error case in mgt-get where a there is no value template. --------- Co-authored-by: Sébastien Levert <[email protected]>
Update rollup and rollup config move rollup config to .mjs file fix ignore path for eslint --------- Co-authored-by: Gavin Barron <[email protected]>
moves rollup configs to .mjs files updates dependencies and configs for rollup
this will ensure that our v4 build can actually be published
…task (#2994) Co-authored-by: Nickii Miaro <[email protected]>
* clean-up react-contoso homepage * remove theme toggle Co-authored-by: Sébastien Levert <[email protected]> * remove theme toggle import --------- Co-authored-by: Sébastien Levert <[email protected]> Co-authored-by: Musale Martin <[email protected]>
adds extended tests for Localization on mgt-person removes the initials property from the default set of strings for mgt-person
* Update the permissions for PR reporting Add contents:read - allows reading commits of the pr Add checks:write - reports the status of the job on the pr Add id-token:write permission
set add button to disabled until task name is provided fix planner localization string
Thank you for creating a Pull Request @gavinbarron. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
musale
previously approved these changes
Feb 7, 2024
musale
approved these changes
Feb 7, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the changes in main to the next/mgt-chat branch