Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add csp to storybook deployments #2902

Merged
merged 2 commits into from
Dec 6, 2023
Merged

chore: add csp to storybook deployments #2902

merged 2 commits into from
Dec 6, 2023

Conversation

gavinbarron
Copy link
Member

@gavinbarron gavinbarron commented Dec 5, 2023

Closes #2901

PR Type

  • Refactor
  • Other... Please describe: Chore

Description of the changes

refactors inline CSS and JavaScript in manager.html and preview.html to be imported into or sourced in the associated JavaScript file
Adds code to the post build processing script to add a CSP meta tag to the HTML page

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@gavinbarron gavinbarron requested a review from a team as a code owner December 5, 2023 19:24
Copy link

github-actions bot commented Dec 5, 2023

📖 The updated storybook is available here

1 similar comment
Copy link

github-actions bot commented Dec 5, 2023

📖 The updated storybook is available here

Copy link

github-actions bot commented Dec 5, 2023

📖 The updated storybook is available here

Copy link

github-actions bot commented Dec 5, 2023

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 81% 100% 0
mgt-components.src.components.mgt-contact 68% 83% 0
mgt-components.src.components.mgt-file 51% 100% 0
mgt-components.src.components.mgt-file-list 56% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 88% 0
mgt-components.src.components.mgt-get 30% 100% 0
mgt-components.src.components.mgt-messages 66% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 81% 65% 0
mgt-components.src.components.mgt-person-card 66% 47% 0
mgt-components.src.components.mgt-picker 78% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 77% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-arrow-options 71% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 78% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 89% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 27% 0
mgt-element.dist.es6.components.src.components 73% 79% 0
mgt-element.dist.es6.mock.src.mock 91% 77% 0
mgt-element.dist.es6.providers.src.providers 85% 72% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 66% 69% 0
mgt-element.src 88% 100% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 80% 85% 0
mgt-element.src.utils 71% 90% 0
Summary 66% (14140 / 21431) 64% (425 / 660) 0

Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 🚀

@gavinbarron gavinbarron merged commit 1796b6b into main Dec 6, 2023
@gavinbarron gavinbarron deleted the feat/csp branch December 6, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[CHORE] Add CSP meta tag to deployed mgt.dev site
2 participants