Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add method to clear selected channel in mgt-teams-channel-picker #2865

Merged
merged 3 commits into from
Nov 20, 2023
Merged

fix: add method to clear selected channel in mgt-teams-channel-picker #2865

merged 3 commits into from
Nov 20, 2023

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented Nov 16, 2023 •
edited
Loading

Closes #2818

PR Type

Bugfix

Description of the changes

Adds clearSelectedItem() method to clear selected channel in mgt-teams-channel-picker

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@Mnickii Mnickii requested a review from a team as a code owner November 16, 2023 12:17
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@sebastienlevert
Copy link
Contributor

@Mnickii works great. The only thing that doesn't is the x that allows clearing it via the UI is still shown after performing it via the new method.

image

@Mnickii
Copy link
Collaborator Author

Mnickii commented Nov 16, 2023

@Mnickii works great. The only thing that doesn't is the x that allows clearing it via the UI is still shown after performing it via the new method.

image

Thanks, nice catch!

@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

sebastienlevert
sebastienlevert previously approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Can you also add the events documentation PR? Thanks!

gavinbarron
gavinbarron requested changes Nov 16, 2023
View reviewed changes
Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how simple this change appears to be, I'd like us to take this opportunity to clean up some aspects of how were handing our selection/removal methods though

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Author Feedback Issue needs response from issue author label Nov 16, 2023
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback Issue needs response from issue author label Nov 20, 2023
@Mnickii Mnickii requested a review from gavinbarron November 20, 2023 16:56
@github-actions GitHub Actions
Copy link

🚀 New react-contoso sample application deployed here

@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 81% 100% 0 ✔
mgt-components.src.components.mgt-contact 68% 83% 0 ➖
mgt-components.src.components.mgt-file 51% 100% 0 ➖
mgt-components.src.components.mgt-file-list 56% 100% 0 ➖
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 88% 0 ❌
mgt-components.src.components.mgt-messages 66% 100% 0 ➖
mgt-components.src.components.mgt-organization 47% 100% 0 ❌
mgt-components.src.components.mgt-person 79% 65% 0 ✔
mgt-components.src.components.mgt-person-card 66% 47% 0 ➖
mgt-components.src.components.mgt-profile 40% 100% 0 ❌
mgt-components.src.components.mgt-theme-toggle 100% 100% 0 ✔
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0 ➖
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0 ✔
mgt-components.src.graph 38% 89% 0 ❌
mgt-components.src.styles 92% 80% 0 ✔
mgt-components.src.utils 79% 28% 0 ✔
mgt-element.dist.es6.components.src.components 73% 79% 0 ➖
mgt-element.dist.es6.mock.src.mock 90% 72% 0 ✔
mgt-element.dist.es6.providers.src.providers 85% 69% 0 ✔
mgt-element.dist.es6.src 91% 80% 0 ✔
mgt-element.dist.es6.utils.src.utils 66% 69% 0 ➖
mgt-element.src 88% 100% 0 ✔
mgt-element.src.components 84% 100% 0 ✔
mgt-element.src.mock 81% 56% 0 ✔
mgt-element.src.providers 80% 85% 0 ✔
mgt-element.src.utils 71% 90% 0 ➖
Summary 65% (12447 / 19051) 64% (416 / 650) 0 ➖

@github-actions GitHub Actions
Copy link

📖 The updated storybook is available here

gavinbarron
gavinbarron approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates on this, it looks really good now.

@gavinbarron gavinbarron merged commit c3a3d82 into main Nov 20, 2023
@gavinbarron gavinbarron deleted the bug-2818 branch November 20, 2023 20:36
@gavinbarron gavinbarron mentioned this pull request Nov 20, 2023
Merged
@gavinbarron gavinbarron mentioned this pull request Feb 5, 2024
Merged
@paaschdigital paaschdigital mentioned this pull request Jun 8, 2024
Open
@paaschdigital paaschdigital mentioned this pull request Jun 8, 2024
Open
This was referenced Jun 20, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinbarron gavinbarron gavinbarron approved these changes

@sebastienlevert sebastienlevert sebastienlevert left review comments

Assignees
No one assigned
Labels
Build: React Contoso Build: Storybook
Projects
Graph Toolkit
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - mgt-channel-picker not able to clear the selected value
3 participants
@Mnickii @sebastienlevert @gavinbarron