Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Servers support #2308

Closed
wants to merge 17 commits into from
Closed

Add Windows Servers support #2308

wants to merge 17 commits into from

Conversation

Evgeniy-uk
Copy link

@Evgeniy-uk Evgeniy-uk commented Jul 5, 2022

  • Hi is it possible to add support for windows server 2016-2022? Is it also possible to integrate with SCCM\Intune?

Microsoft Reviewers: Open in CodeFlow

Trenly and others added 17 commits June 16, 2022 10:28
This change allows for argument aliases to be more than 1 character
* Init manifest installer validation

* Init test cases and misc enhancements

* Adding more unit tests

* Updated manifest validation code

* Updated messages and misc enhancements

* Added UT for version number struct

* Fixed unit test

* Added flag and handle installer error

* Updated validate command default options

* Addressed comment

* Addressed comment

* Addressed comment

* Addressed comments

* Addressed comment

* Check if package is contained within bundle

* Adddressed comment and added treatErrorAsWarning

* Updated UT for versions

* Addressed comments

* Exclude msixbundle for spelling checker

* Addressed comments

* Addressed comments

* Addressed comments

* Addressed comments

* Addressed comments

* Addressed comments

* Updated error message

* Fixed Versions merge conflict

* Addressed comments + added one more UT

* Updated test yaml package id

* Addressed comment

* Addressed comment
…tion (#2221)

The goal of this change is to expose functionality to run the installed package correlation and gather the results.  This will be used to validate and enhance manifests and allows us to use the same correlation code throughout the system.

The biggest changes to existing code are:
1. Moving the JSON utility methods out of Repository and into Common
2. Moving the correlation code to be object oriented, enabling easier reuse (and allowing for more control in the future)

Beyond those changes, the majority of the work is in creating the JSON (de)serialization and handling updating the metadata that has been collected.

More work is still needed to:
1. Collect more information for diagnostic purposes, like the top results for diagnostics when there is no confident match.
2. Leveraging the previous metadata results to improve correlation.
3. Enable more control over weighting the correlation heuristics, enabling a difference between running on an end user system and in a "clean room" of validation.
Co-authored-by: msftbot[bot] <48340428+msftbot[bot]@users.noreply.github.com>
@Evgeniy-uk Evgeniy-uk requested a review from a team as a code owner July 5, 2022 11:44
@ghost
Copy link

ghost commented Jul 5, 2022

CLA assistant check
All CLA requirements met.

@denelon
Copy link
Contributor

denelon commented Jul 5, 2022

@Evgeniy-uk

We are actively working on Intune integration via:

We will also be bringing support to Windows server, but there are several external dependencies outside of Windows Package Manager necessary to make that happen.

I'm closing this PR as it affects many different files that do not appear to be related to the topic. Also, localization is handled by a separate team. If you have suggestions, we can submit them internally.

@denelon denelon closed this Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants