Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Show package tags #2235

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Feat: Show package tags #2235

merged 2 commits into from
Jun 21, 2022

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Jun 10, 2022


PS D:\Git\winget-cli> wingetdev show vscode
Found Microsoft Visual Studio Code [Microsoft.VisualStudioCode]
Version: 1.68.1
Publisher: Microsoft Corporation
Publisher Url: https://www.microsoft.com/
Moniker: vscode
Description: Microsoft Visual Studio Code is a code editor redefined and optimized for building and debugging modern web and cloud applications. Microsoft Visual Studio Code is free and available on your favorite platform - Linux, macOS, and Windows.
Homepage: https://code.visualstudio.com
License: Microsoft Software License
License Url: https://code.visualstudio.com/license
Privacy Url: https://privacy.microsoft.com/
Tags:
  developer-tools
  editor
Installer:
  Type: inno
  Download Url: https://az764295.vo.msecnd.net/stable/30d9c6cd9483b2cc586687151bcbcd635f373630/VSCodeUserSetup-x64-1.68.1.exe
  SHA256: 19a218dbc013d776472acb449e2e6d3648b53a7f02d1fea64333ebaa3ab696a1
Microsoft Reviewers: Open in CodeFlow

@Trenly Trenly requested a review from a team as a code owner June 10, 2022 04:56
@florelis
Copy link
Member

Why not add the tags to the normal output of show instead of having a separate argument for it? It seems to me like the reasons to have the versions listed separately don't apply for the tags.

@Trenly
Copy link
Contributor Author

Trenly commented Jun 10, 2022

Why not add the tags to the normal output of show instead of having a separate argument for it? It seems to me like the reasons to have the versions listed separately don't apply for the tags.

Because iirc the normal show will show information, and --tags will show the tags from all locales.

@florelis
Copy link
Member

florelis commented Jun 10, 2022

  1. Why would I want to see tags from other locales? For example, if I do winget show Mozilla.Firefox, I probably don't want to see all tags "browser", "navegador", "браузер", "浏览器" that all mean just "browser".
  2. Why can't that be part of all the other information?

But now that you bring up the locale in show, I think it could use the --locale argument to show the appropriate info.
Edit: opened #2238

@Trenly
Copy link
Contributor Author

Trenly commented Jun 10, 2022

Thats a fair point; I was going based just on the issue, but I can see how just showing the tags would be better

@denelon denelon linked an issue Jun 10, 2022 that may be closed by this pull request
@ghost ghost added the Issue-Feature This is a feature request for the Windows Package Manager client. label Jun 20, 2022
Copy link
Member

@florelis florelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be good to add this to the unit tests for show.

@florelis
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ppvnf
Copy link

ppvnf commented Oct 10, 2022

I've tested v1.4.2161-preview and winget show package.id indeed shows the package's tag, however it's not possible to use winget show --tag as proposed in #530. Is there any reason for that? Thanks.

Captura de tela 2022-10-10 182907

@Trenly
Copy link
Contributor Author

Trenly commented Oct 10, 2022

I've tested v1.4.2161-preview and winget show package.id indeed shows the package's tag, however it's not possible to use winget show --tag as proposed in #530. Is there any reason for that? Thanks.

Tags are per version and per locale. To implement it as described in the original request would require either selection of a version and locale, or to aggregate all the tags from all locales and versions which would produce unwieldly data.

Why would I want to see tags from other locales? For example, if I do winget show Mozilla.Firefox, I probably don't want to see all tags "browser", "navegador", "браузер", "浏览器" that all mean just "browser".

The default behavior then would have to be to show the latest version and applicable locale (or defaultLocale if none were applicable), which is the same behavior as integrating it directly into the show command. If you read through the history above, I actually had implemented it as a separate argument initially, but then upon feedback it was changed since it would essentially be showing just the tags portion of the output and it doesn't make sense to require a separate argument for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to list tags of a specific Package
3 participants