Bump Microsoft.VisualStudio.Diagnostics.Utilities to a release-branch build to fix SymbolCheck - #16322
Merged
Jakub Jareš (nohwnd) merged 2 commits intoJul 30, 2026
Conversation
The pin at 18.3.11401.5 is not from a VS release branch, so its DLLs have no symbols on the symbol server and SymbolCheck fails on every insertion. This property drives three packages - Diagnostics.Utilities, Enterprise.AspNetHelper and ArchitectureTools.PEReader - whose DLLs are bundled into the CLI vsix, which is exactly the four files reported by the failing check. 18.3.11611.365 is already used for MicrosoftInternalTestPlatformExtensions in this same file, so it is a known-good release branch build.
Azat Mukhametshin (azat-msft)
added a commit
that referenced
this pull request
Jul 30, 2026
The pin at 18.3.11401.5 is not from a VS release branch, so its DLLs have no symbols on the symbol server and SymbolCheck fails on every insertion. This property drives three packages - Diagnostics.Utilities, Enterprise.AspNetHelper and ArchitectureTools.PEReader - whose DLLs are bundled into the CLI vsix. 18.3.11611.365 is already used for MicrosoftInternalTestPlatformExtensions in this same file, so it is a known-good release branch build. Forward-port of #16322 (rel/18.10) so 18.11 does not regress.
18.3.11611.365 was chosen because a sibling property already used it, but symchk against msdl shows it has no symbols published - same failure as the original pin. 18.3.11527.243 is the newest version where all three packages pass symchk.
Amaury Levé (Evangelink)
approved these changes
Jul 30, 2026
Amaury Levé (Evangelink)
enabled auto-merge (squash)
July 30, 2026 10:16
Jakub Jareš (nohwnd)
approved these changes
Jul 30, 2026
Jakub Jareš (nohwnd)
disabled auto-merge
July 30, 2026 10:36
Jakub Jareš (nohwnd)
deleted the
fix/symcheck-diagnostics-utilities-18.10
branch
July 30, 2026 11:03
Amaury Levé (Evangelink)
pushed a commit
that referenced
this pull request
Jul 30, 2026
… build to fix SymbolCheck (main) (#16323) * Bump Microsoft.VisualStudio.Diagnostics.Utilities to 18.3.11611.365 The pin at 18.3.11401.5 is not from a VS release branch, so its DLLs have no symbols on the symbol server and SymbolCheck fails on every insertion. This property drives three packages - Diagnostics.Utilities, Enterprise.AspNetHelper and ArchitectureTools.PEReader - whose DLLs are bundled into the CLI vsix. 18.3.11611.365 is already used for MicrosoftInternalTestPlatformExtensions in this same file, so it is a known-good release branch build. Forward-port of #16322 (rel/18.10) so 18.11 does not regress. * Correct version to 18.3.11527.243 (verified to have symbols) 18.3.11611.365 was chosen because a sibling property already used it, but symchk against msdl shows it has no symbols published - same failure as the original pin. 18.3.11527.243 is the newest version where all three packages pass symchk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
SymbolCheckfailure blocking VS Test Platform insertions into VS.Problem
The VS insertion PR for
rel/18.10/20260727.2(VS !763202) failsInsertion Symbol Checkwith 4 unarchived files inMicrosoft.VisualStudio.TestTools.TestPlatform.V2.CLI:microsoft.visualstudio.enterprise.aspnethelper.dllmicrosoft.visualstudio.diagnostics.utilities.dllmicrosoft.visualstudio.architecturetools.pereader.dllextensions\microsoft.visualstudio.architecturetools.pereader.dllAuto-filed bug: 3038905.
Cause
All four come from a single version property in
eng/Versions.props, which drives threePackageReferences inMicrosoft.TestPlatform.csproj(lines 98-100) whose DLLs are bundled into the CLI vsix (...V2.CLI.csprojlines 104-109; PEReader ships twice, root +Extensions\).The pin sits directly under a comment warning about this exact failure:
18.3.11401.5has never been touched sinced187201("Onboard to arcade") and is not a release-branch build, so no symbols were ever published for it.Fix
Bump to
18.3.11527.243- the newest stable on thevs-implfeed, and already used byMicrosoftInternalTestPlatformExtensionson line 76 of this same file, so it is a known-good release-branch build.One line, covers all three packages and all four files.
Notes
rel/18.10because that is what the failing insertion is built from. Needs forward-porting tomain, which carries the same stale pin (18.11 would otherwise regress).BackwardCompatibilityTest- that is handled VS-side by VS !764445, adding APICompat suppressions for the test-session APIs removed in Remove the experimental test session feature #16231.Verification
Checked with
symchkfromVS.Tools.VerifyInsertion.Toolsagainst msdl, per the guidance on bug 3038905:Control -
Microsoft.VisualStudio.Interop.dll, bundled in the same vsix and not reported by the failing check -PASSED, confirming the method is sound.Scan of recent versions of
Microsoft.VisualStudio.Diagnostics.Utilities:Symbol publishing is evidently inconsistent across builds, so the version cannot be picked by recency alone - it has to be checked.
At 18.3.11527.243, all three packages pass:
(
Diagnostics.Utilities,Enterprise.AspNetHelper,ArchitectureTools.PEReader)