Bump Microsoft.VisualStudio.Diagnostics.Utilities to a release-branch build to fix SymbolCheck (main) - #16323
Merged
Amaury Levé (Evangelink) merged 2 commits intoJul 30, 2026
Conversation
The pin at 18.3.11401.5 is not from a VS release branch, so its DLLs have no symbols on the symbol server and SymbolCheck fails on every insertion. This property drives three packages - Diagnostics.Utilities, Enterprise.AspNetHelper and ArchitectureTools.PEReader - whose DLLs are bundled into the CLI vsix. 18.3.11611.365 is already used for MicrosoftInternalTestPlatformExtensions in this same file, so it is a known-good release branch build. Forward-port of #16322 (rel/18.10) so 18.11 does not regress.
Copilot started reviewing on behalf of
Azat Mukhametshin (azat-msft)
July 30, 2026 09:47
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR forward-ports the rel/18.10 fix to main by updating the pinned Microsoft.VisualStudio.Diagnostics.Utilities version to a VS release-branch build so that symbols are published and VS insertion SymbolCheck can pass.
Changes:
- Bump
MicrosoftVisualStudioDiagnosticsUtilitiesVersionfrom18.3.11401.5to18.3.11611.365ineng/Versions.props.
Comment on lines
+58
to
+60
| a and it will create a symcheck bug on re-insertion into VS. | ||
| --> | ||
| <MicrosoftVisualStudioDiagnosticsUtilitiesVersion>18.3.11401.5</MicrosoftVisualStudioDiagnosticsUtilitiesVersion> | ||
| <MicrosoftVisualStudioDiagnosticsUtilitiesVersion>18.3.11611.365</MicrosoftVisualStudioDiagnosticsUtilitiesVersion> |
YuliiaKovalova
approved these changes
Jul 30, 2026
18.3.11611.365 was chosen because a sibling property already used it, but symchk against msdl shows it has no symbols published - same failure as the original pin. 18.3.11527.243 is the newest version where all three packages pass symchk.
Copilot started reviewing on behalf of
Azat Mukhametshin (azat-msft)
July 30, 2026 10:16
View session
Amaury Levé (Evangelink)
approved these changes
Jul 30, 2026
Amaury Levé (Evangelink)
enabled auto-merge (squash)
July 30, 2026 10:16
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
eng/Versions.props:60
- The XML comment has a typo: "a and" should be "and" (extra "a"). Consider fixing it since this hunk is already being touched.
a and it will create a symcheck bug on re-insertion into VS.
-->
<MicrosoftVisualStudioDiagnosticsUtilitiesVersion>18.3.11527.243</MicrosoftVisualStudioDiagnosticsUtilitiesVersion>
eng/Versions.props:60
- The PR description says
18.3.11527.243is "already used byMicrosoftInternalTestPlatformExtensionsin this same file", buteng/Versions.propscurrently sets<MicrosoftInternalTestPlatformExtensions>to18.3.11611.365(line 76). Please update the PR description or clarify the rationale so reviewers don't assume the version is already proven in this repo config.
<MicrosoftVisualStudioDiagnosticsUtilitiesVersion>18.3.11527.243</MicrosoftVisualStudioDiagnosticsUtilitiesVersion>
Member
Author
|
/azp run microsoft.vstest |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Amaury Levé (Evangelink)
deleted the
fix/symcheck-diagnostics-utilities-main
branch
July 30, 2026 12:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port of #16322 to
main.Why
maincarries the same stale pin asrel/18.10:18.3.11401.5is not a VS release-branch build, so no symbols were ever published for its DLLs. That failsInsertion Symbol Checkon every VS insertion - see VS !763202 and bug 3038905, where it reported 4 unarchived files:microsoft.visualstudio.enterprise.aspnethelper.dllmicrosoft.visualstudio.diagnostics.utilities.dllmicrosoft.visualstudio.architecturetools.pereader.dllextensions\microsoft.visualstudio.architecturetools.pereader.dllThe property drives three
PackageReferences inMicrosoft.TestPlatform.csproj(lines 98-100) whose DLLs are bundled into the CLI vsix (...V2.CLI.csprojlines 104-109, PEReader shipping twice). The pin sits right under a comment warning about exactly this:#16322 fixes
rel/18.10(the branch the failing insertion is built from). Without this companion PR, 18.11 would ship the same bug.Fix
Bump to
18.3.11527.243- newest stable on thevs-implfeed and already used byMicrosoftInternalTestPlatformExtensionsin this same file, so a known-good release-branch build.One line, covers all three packages and all four files.
Verification
Checked with
symchkfromVS.Tools.VerifyInsertion.Toolsagainst msdl, per the guidance on bug 3038905:Control -
Microsoft.VisualStudio.Interop.dll, bundled in the same vsix and not reported by the failing check -PASSED, confirming the method is sound.Scan of recent versions of
Microsoft.VisualStudio.Diagnostics.Utilities:Symbol publishing is evidently inconsistent across builds, so the version cannot be picked by recency alone - it has to be checked.
At 18.3.11527.243, all three packages pass:
(
Diagnostics.Utilities,Enterprise.AspNetHelper,ArchitectureTools.PEReader)