Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bgashler1/color b #8587

Closed
wants to merge 9 commits into from
Closed

Conversation

bgashler1
Copy link
Contributor

@bgashler1 bgashler1 commented Jun 30, 2016

Alternate version, based on feedback from PR #8238.

Changes:

  • Removed scroll decoration modifications (they are default now)
  • Removed gradient trick and now instead use the viewlet background color so the tab well still is different from the find/replace. The first tab with its own background, in turn, is able to differentiate the tab well from the viewlet, so everything is clearly separated.
  • Made inactive tabs have their own background color that is different from tab well.

This also addresses all feedback in #8564

Thanks @bpasero and @isidorn for your feedback. I'm sure we can continue refining this in July.

@bgashler1 bgashler1 added workbench-tabs VS Code editor tab issues color labels Jun 30, 2016
@bgashler1 bgashler1 added this to the June 2016 milestone Jun 30, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @bpasero and @isidorn to be potential reviewers

@bpasero
Copy link
Member

bpasero commented Jul 1, 2016

Great, see my comment in #8564 (comment) why I did not just merge this PR directly but refined it a bit.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
workbench-tabs VS Code editor tab issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants