Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab title background should not be current line highlight #8294

Closed
jrieken opened this issue Jun 28, 2016 · 2 comments
Closed

Tab title background should not be current line highlight #8294

jrieken opened this issue Jun 28, 2016 · 2 comments
Assignees
@bpasero @stevencl @bgashler1
Labels
*duplicate Issue identified as a duplicate of another issue(s) ux User experience issues workbench-tabs VS Code editor tab issues
Milestone
June 2016

Comments

@jrieken
Copy link
Member

jrieken commented Jun 28, 2016

This is a unhappy collision of styles (GitHub Clean White theme) and the background color of the tab area. I wonder if we should use the background color of viewlets inside of the darker tone?

screen shot 2016-06-28 at 12 02 21
@jrieken jrieken added ux User experience issues workbench-tabs VS Code editor tab issues labels Jun 28, 2016
@bpasero
Copy link
Member

bpasero commented Jun 28, 2016

Yeah, @bgashler1 and me work on this still and we will pick a color closer to viewlet.

@bpasero bpasero added this to the June 2016 milestone Jun 28, 2016
bgashler1 added a commit to bgashler1/vscode that referenced this issue Jun 30, 2016
@bgashler1
Differentiate tab well color; theme for light tabs
eecde9e 
Addresses microsoft#7649, microsoft#8294
@bpasero bpasero mentioned this issue Jun 30, 2016
Closed
@bpasero
Copy link
Member

bpasero commented Jun 30, 2016

#8564

@bpasero bpasero closed this as completed Jun 30, 2016
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 30, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@stevencl stevencl

@bgashler1 bgashler1

Labels
*duplicate Issue identified as a duplicate of another issue(s) ux User experience issues workbench-tabs VS Code editor tab issues
Projects
None yet
Milestone
June 2016
Development

No branches or pull requests
4 participants
@bpasero @stevencl @jrieken @bgashler1