Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find widget does not blend well when tabs enabled #7649

Closed
isidorn opened this issue Jun 14, 2016 · 8 comments
Closed

Find widget does not blend well when tabs enabled #7649

isidorn opened this issue Jun 14, 2016 · 8 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) ux User experience issues workbench-tabs VS Code editor tab issues
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Jun 14, 2016

IMHO the find widget does not visually blend well when tabs are enabled
Two similar gray colors and no seperation between them does not look good to me.

Just my 2 cents so feel free to close

screen shot 2016-06-14 at 11 52 28

@isidorn isidorn added ux User experience issues workbench-tabs VS Code editor tab issues labels Jun 14, 2016
@bpasero bpasero assigned stevencl and bgashler1 and unassigned bpasero Jun 14, 2016
@bpasero
Copy link
Member

bpasero commented Jun 14, 2016

I took the following color rule for the tabs container background: rgba(128, 128, 128, 0.2)

(this is the same as the color we use for split views header, e.g. in debug viewlet).

@bpasero bpasero added this to the Backlog milestone Jun 14, 2016
@isidorn
Copy link
Contributor Author

isidorn commented Jun 14, 2016

I am not arguing against that color just not sure if there should be some spearation between the find widget and the header.

@stevencl
Copy link
Member

stevencl commented Jun 14, 2016

Here's what it looks like using the same colour as the selection colour in the explorer:
image

@stevencl
Copy link
Member

I am not sure about adding another separator if the contrasting colour works better?

@bpasero
Copy link
Member

bpasero commented Jun 14, 2016

/cc @alexandrudima

@bpasero bpasero removed this from the Backlog milestone Jun 14, 2016
@bpasero bpasero added this to the June 2016 milestone Jun 14, 2016
@stevencl
Copy link
Member

We discussed and agreed that we should look at the colours used throughout the product now that we have tabs enabled. @bgashler1 - this is something you and I should talk about.

@bgashler1
Copy link
Contributor

Agreed. Steven and I will be meeting next week to discuss.

This was referenced Jun 21, 2016
@bpasero bpasero self-assigned this Jun 28, 2016
bgashler1 added a commit to bgashler1/vscode that referenced this issue Jun 30, 2016
@bpasero
Copy link
Member

bpasero commented Jun 30, 2016

#8564

@bpasero bpasero closed this as completed Jun 30, 2016
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 30, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) ux User experience issues workbench-tabs VS Code editor tab issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants