Add community support for building with MinGW by cristianadam · Pull Request #9137 · microsoft/vcpkg

cristianadam · 2019-11-28T17:01:12Z

The merge request adds the following commits:

Add needed changes to build vcpkg itself with MinGW.
Tested with the standalone StephanTLavavej/mingw-distro.
Add toolchain support for building with MinGW compilers.
Add community tripplets to build x86, x64, arm, arm 64.

The arm and arm64 triplets I tested with the Clang-LLVM/MinGW toolchain.

msftclas · 2019-11-28T17:01:25Z

All CLA requirements met.

cbezault · 2019-12-03T19:22:07Z

Does the [[maybe_unused]] attribute you added compile with vs2015?

cristianadam · 2019-12-03T19:34:43Z

Does the [[maybe_unused]] attribute you added compile with vs2015?

yes it does. See:

$ cmake -GNinja -DCMAKE_BUILD_TYPE=Release ..\toolsrc
-- The C compiler identification is MSVC 19.0.24215.1
-- The CXX compiler identification is MSVC 19.0.24215.1
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - not found
-- Found Threads: TRUE
-- Configuring done
-- Generating done
-- Build files have been written to: C:/Projects/github/vcpkg/build-msvc2015

c:\Projects\github\vcpkg\build-msvc2015
$ cmake --build .
[0/2 ?/sec]Re-checking globbed directories...
[46/84 1.0/sec]Building CXX object CMakeFiles\vcpkglib.dir\src\vcpkg\logicexpression.cpp.obj
FAILED: CMakeFiles/vcpkglib.dir/src/vcpkg/logicexpression.cpp.obj
"C:\PROGRA~2\Microsoft Visual Studio 14.0\VC\bin\x86_amd64\cl.exe"  /nologo /TP -DDISABLE_METRICS=0 -IC:\Projects\github\vcpkg\toolsrc\include /DWIN32 /D_WINDOWS  /GR /EHsc /MD /O2 /Ob2 /DNDEBUG   -FC -std:c++latest -W4 -WX /showIncludes /FoCMakeFiles\vcpkglib.dir\src\vcpkg\logicexpression.cpp.obj /FdCMakeFiles\vcpkglib.dir\ /FS -c C:\Projects\github\vcpkg\toolsrc\src\vcpkg\logicexpression.cpp
c:\projects\github\vcpkg\toolsrc\src\vcpkg\logicexpression.cpp(74) : error C2220: warning treated as error - no 'object' file generated
c:\projects\github\vcpkg\toolsrc\src\vcpkg\logicexpression.cpp(74) : warning C4702: unreachable code
[55/84 1.1/sec]Building CXX object CMakeFiles\vcpkglib.dir\src\vcpkg\vcpkgcmdarguments.cpp.obj
ninja: build stopped: subcommand failed.

c:\Projects\github\vcpkg\build-msvc2015
$ cmake --build .
[0/2 ?/sec]Re-checking globbed directories...
[30/30 1.2/sec]Linking CXX executable vcpkg-test.exe

But only after applying this unrelated patch:

diff --git a/toolsrc/src/vcpkg/logicexpression.cpp b/toolsrc/src/vcpkg/logicexpression.cpp
index ccb8b00c4..eed27bdf3 100644
--- a/toolsrc/src/vcpkg/logicexpression.cpp
+++ b/toolsrc/src/vcpkg/logicexpression.cpp
@@ -68,11 +68,11 @@ namespace vcpkg
                 add_error("Invalid logic expression");
             }

-            if (err)
-            {
-                err->print_error();
-                final_result = false;
-            }
+//             if (err)
+//             {
+//                 err->print_error();
+//                 final_result = false;
+//             }
         }

         bool get_result() const { return final_result; }

cbezault · 2019-12-03T21:00:54Z

Could you please make a PR for that unrelated patch. It would be much appreciated. We're supposed to support vs2015.
Edit: Sorry didn't look at what you were actually doing. Someone needs to fix that issue but it is unnecessary for this PR to go through.

tstavrianos · 2019-12-10T11:28:58Z

When trying to use this with nuwen-mingw to build boost-stacktrace (and boost in general) it fails with this in install-x64-mingw-dbg-out.log:

g++.exe: error: x86_64-windows-gnu: No such file or directory

Successfully built sdl2 with it and boost is not a huge issue (as nuwen-mingw has it already included).

tstavrianos · 2019-12-10T11:33:26Z

Some extra info that might help, it fails earlier on if I don't have boost-build:x86-windows installed:

CMake Error at installed/x64-mingw/share/boost-build/boost-modular-build.cmake:18 (message):
  The x86 boost-build tools must be installed to build for non-x86/x64
  platforms.  Please run `vcpkg install boost-build:x86-windows`.
Call Stack (most recent call first):
  ports/boost-stacktrace/portfile.cmake:14 (boost_modular_build)
  scripts/ports.cmake:94 (include)

cristianadam · 2019-12-11T18:02:56Z

Some extra info that might help, it fails earlier on if I don't have boost-build:x86-windows installed:

CMake Error at installed/x64-mingw/share/boost-build/boost-modular-build.cmake:18 (message):
  The x86 boost-build tools must be installed to build for non-x86/x64
  platforms.  Please run `vcpkg install boost-build:x86-windows`.
Call Stack (most recent call first):
  ports/boost-stacktrace/portfile.cmake:14 (boost_modular_build)
  scripts/ports.cmake:94 (include)

Not all packages would work with this PR, especially those that require a custom build system like boost.

Somebody would have to make sure that boost-build:x64-mingw gets properly bootstrapped.

dan-shaw · 2019-12-13T23:58:32Z

@cristianadam Thanks for the PR! We like the idea and implementation. However, since we don't officially support MinGW, the triplet files will need to go into a separate folder: community-triplets. We don't have support for this yet, so we will have to wait before we can merge this.

alcroito · 2019-12-14T01:44:49Z

Hi. Would it be acceptable to merge the PR without the triplet files?

cristianadam · 2019-12-17T17:57:22Z

@dan-shaw I removed the triplets from the MR.

The x64-mingw triplet is nothing more than:

set(VCPKG_TARGET_ARCHITECTURE x64)
set(VCPKG_CRT_LINKAGE dynamic)
set(VCPKG_LIBRARY_LINKAGE static)
set(VCPKG_ENV_PASSTHROUGH PATH)

set(VCPKG_CMAKE_SYSTEM_NAME MinGW)

I think if vcpkg would have the MR merged, having to write a six line triplet file won't be such a big deal 😄

cristianadam · 2019-12-23T07:11:26Z

We need to wait for OSX CI to fix before merge this PR.

The CI is stuck since 16th of December.
How can I retriger the OSX CI? On previous commits of this PR everything was green.

dan-shaw · 2019-12-23T23:54:20Z

I don't think we can, the MacOS CI pipeline is still down.

cristianadam · 2020-01-06T18:14:22Z

I don't think we can, the MacOS CI pipeline is still down.

The macOS CI pipeline is down since 2nd of December 😮

GitHub Actions is up and running fine on macOS, maybe you guys should switch to GitHub Actions ? 😄

dan-shaw · 2020-01-06T20:54:14Z

We might merge this and not wait for the MacOS CIs to be back up (since it is taking a while). Pinging @ras0219 for review

cristianadam · 2020-01-10T14:45:48Z

The vcpkg-osx-PR is still broken.

I've seen that release 2019.12 was done.
What can we do as externals?

JackBoosY · 2020-01-13T02:22:10Z

@cristianadam See #9600.

vicroms · 2020-01-16T22:24:00Z

/azp run

cristianadam · 2020-01-17T15:10:08Z

What's the difference between vcpkg-osx-PR and vcpkg-osx-PR-test?

strega-nil · 2020-01-17T19:22:57Z

@cristianadam vcpkg-osx-PR-test is a better version of vcpkg-osx-PR; vcpkg-osx-PR has been deprecated.

matwey · 2020-01-17T19:45:58Z

MinGW triplets are not included, but writing a MinGW triplet is as easy as:

Are you going to contribute MinGW triplets later? I think it may be very productive idea when vcpkg is used in CI. Then CI configurations for Visual Studio and MinGW can differ only by the triplet in use.

scripts/cmake/vcpkg_common_definitions.cmake

toolsrc/src/vcpkg/sourceparagraph.cpp

Tested with MSYS2 MinGW 8.3.0, gcc-mcf.lhmouse MinGW 9.2.1, and StephanTLavavej/mingw-distro!

From your MinGW configured shell you could just use vcpkg to configure packages. An x64-mingw triplet would look like: ``` set(VCPKG_TARGET_ARCHITECTURE x64) set(VCPKG_CRT_LINKAGE dynamic) set(VCPKG_LIBRARY_LINKAGE static) set(VCPKG_ENV_PASSTHROUGH PATH) set(VCPKG_CMAKE_SYSTEM_NAME MinGW) ```

vicroms · 2020-01-17T22:43:08Z

Hi @cristianadam

Now that Community Triplets have been merged in #7976 can you please add a x64-mingw triplet in triplets/community/.

x64 tested with https://github.com/StephanTLavavej/mingw-distro x86, arm64, arm tested with https://github.com/mstorsjo/llvm-mingw

cristianadam · 2020-01-17T22:59:49Z

Hi @cristianadam

Now that Community Triplets have been merged in #7976 can you please add a x64-mingw triplet in triplets/community/.

Done. The original triplets that I have had are back in. 🤘

vicroms · 2020-01-17T23:35:57Z

Thanks for the PR!

scripts/cmake/vcpkg_common_definitions.cmake

* Add support for building with MinGW Tested with MSYS2 MinGW 8.3.0, gcc-mcf.lhmouse MinGW 9.2.1, and StephanTLavavej/mingw-distro! * Add MinGW toolchain From your MinGW configured shell you could just use vcpkg to configure packages. An x64-mingw triplet would look like: ``` set(VCPKG_TARGET_ARCHITECTURE x64) set(VCPKG_CRT_LINKAGE dynamic) set(VCPKG_LIBRARY_LINKAGE static) set(VCPKG_ENV_PASSTHROUGH PATH) set(VCPKG_CMAKE_SYSTEM_NAME MinGW) ``` * Add MinGW community tripplets x64 tested with https://github.com/StephanTLavavej/mingw-distro x86, arm64, arm tested with https://github.com/mstorsjo/llvm-mingw

cristianadam mentioned this pull request Nov 28, 2019

Consider adding vcpkg StephanTLavavej/mingw-distro#74

Closed

cristianadam force-pushed the build-with-mingw branch from 2e2cb37 to 70f2e4f Compare November 28, 2019 22:50

cristianadam mentioned this pull request Nov 28, 2019

std::filesystem support library is missing StephanTLavavej/mingw-distro#72

Closed

PhoebeHui requested a review from JackBoosY November 29, 2019 08:03

JackBoosY requested a review from vicroms November 29, 2019 09:17

cristianadam force-pushed the build-with-mingw branch 3 times, most recently from 35d3037 to 385ff14 Compare November 29, 2019 14:55

grdowns assigned vicroms Dec 2, 2019

dan-shaw added the needs-further-review label Dec 11, 2019

dan-shaw added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed needs-further-review labels Dec 13, 2019

cristianadam force-pushed the build-with-mingw branch from 385ff14 to 80ecd29 Compare December 16, 2019 12:56

JackBoosY approved these changes Dec 18, 2019

View reviewed changes

This was referenced Dec 18, 2019

vcpkg under mingw #4418

Closed

Adding triplet/toolchain for mingw on Windows #3752

Closed

How supported / not supported is MinGW on Windows? #7794

Closed

dan-shaw added the needs-further-review label Dec 19, 2019

dan-shaw assigned ras0219-msft and dan-shaw Dec 20, 2019

JackBoosY mentioned this pull request Jan 7, 2020

[many ports] Support building with MinGW toolchain #8940

Merged

vicroms requested changes Jan 17, 2020

View reviewed changes

scripts/cmake/vcpkg_common_definitions.cmake Outdated Show resolved Hide resolved

toolsrc/src/vcpkg/sourceparagraph.cpp Outdated Show resolved Hide resolved

cristianadam force-pushed the build-with-mingw branch from 80ecd29 to e77da72 Compare January 17, 2020 21:44

cristianadam requested a review from vicroms January 17, 2020 21:48

cristianadam added 2 commits January 17, 2020 23:38

Add support for building with MinGW

a230f70

Tested with MSYS2 MinGW 8.3.0, gcc-mcf.lhmouse MinGW 9.2.1, and StephanTLavavej/mingw-distro!

cristianadam force-pushed the build-with-mingw branch from 547dbf4 to ff32f46 Compare January 17, 2020 22:38

Add MinGW community tripplets

835235f

x64 tested with https://github.com/StephanTLavavej/mingw-distro x86, arm64, arm tested with https://github.com/mstorsjo/llvm-mingw

vicroms approved these changes Jan 17, 2020

View reviewed changes

vicroms removed the needs-further-review label Jan 17, 2020

vicroms merged commit 38b9590 into microsoft:master Jan 17, 2020

vicroms changed the title ~~Add support for building with MinGW~~ Add community support for building with MinGW Jan 17, 2020

jesseschalken reviewed Jan 23, 2020

View reviewed changes

scripts/cmake/vcpkg_common_definitions.cmake Show resolved Hide resolved

cristianadam mentioned this pull request Jan 23, 2020

MinGW: Fix vcpkg common definitions #9807

Merged

cristianadam deleted the build-with-mingw branch January 23, 2020 19:02

traversaro mentioned this pull request Apr 26, 2020

Support ROBOTOLOGY_USES_OCTAVE on Windows robotology/robotology-superbuild#139

Closed

Conversation

cristianadam commented Nov 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msftclas commented Nov 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cbezault commented Dec 3, 2019

Uh oh!

cristianadam commented Dec 3, 2019

Uh oh!

cbezault commented Dec 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tstavrianos commented Dec 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tstavrianos commented Dec 10, 2019

Uh oh!

cristianadam commented Dec 11, 2019

Uh oh!

dan-shaw commented Dec 13, 2019

Uh oh!

alcroito commented Dec 14, 2019

Uh oh!

cristianadam commented Dec 17, 2019

Uh oh!

cristianadam commented Dec 23, 2019

Uh oh!

dan-shaw commented Dec 23, 2019

Uh oh!

cristianadam commented Jan 6, 2020

Uh oh!

dan-shaw commented Jan 6, 2020

Uh oh!

cristianadam commented Jan 10, 2020

Uh oh!

JackBoosY commented Jan 13, 2020

Uh oh!

vicroms commented Jan 16, 2020

Uh oh!

cristianadam commented Jan 17, 2020

Uh oh!

strega-nil commented Jan 17, 2020

Uh oh!

matwey commented Jan 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vicroms commented Jan 17, 2020

Uh oh!

cristianadam commented Jan 17, 2020

Uh oh!

vicroms commented Jan 17, 2020

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

cristianadam commented Nov 28, 2019 •

edited

Loading

msftclas commented Nov 28, 2019 •

edited

Loading

cbezault commented Dec 3, 2019 •

edited

Loading

tstavrianos commented Dec 10, 2019 •

edited

Loading

matwey commented Jan 17, 2020 •

edited

Loading