Merged
Conversation
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cbezault
approved these changes
Sep 13, 2019
Contributor
cbezault
left a comment
cbezault
left a comment
There was a problem hiding this comment.
LGTM, my one comment is more of a nit than anything.
| for (auto&& path : fs.get_files_non_recursive(triplets_dir)) | ||
| { | ||
| output.push_back(path.stem().filename().string()); | ||
| if (fs::is_regular_file(fs.status(VCPKG_LINE_INFO, path))) |
Contributor
There was a problem hiding this comment.
I wish the error that this output made it more obvious that it explicitly was the triplet path that could not be found.
This was referenced Sep 23, 2019
ras0219-msft
requested changes
Sep 24, 2019
Contributor
|
/azp run |
kevinlul
added a commit
to kevinlul/edopro-vcpkg-cache
that referenced
this pull request
Jan 22, 2020
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
* Move untested triplets to Community Triplets * Document community triplets * Load community triplets by default and alert when using one * [triplets] Merge documentation of community triplets * Bump version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new folder
<vcpkg-root>/triplets/communitywhere commonly requested triplets will be hosted.Community Triplets, unlike regular triplets, won't be tested during CI. This means that no regressions will be reported for code changes that break compatibility with community triplets.
These triplets are disabled by default but can be enabled by passing the
--overlay-triplets=<path-to-vcpkg>/triplets/communityoption in your commands.