[many ports] Support building with MinGW toolchain#8940
Merged
ras0219-msft merged 7 commits intomicrosoft:masterfrom Feb 12, 2020
Merged
[many ports] Support building with MinGW toolchain#8940ras0219-msft merged 7 commits intomicrosoft:masterfrom
ras0219-msft merged 7 commits intomicrosoft:masterfrom
Conversation
Contributor
|
/azp run |
grdowns
changed the title
Contributor
|
Error in Windows: |
Contributor
|
/azp run |
Contributor
Author
@JackBoosY I believe this error has nothing to do with my changes. Maybe I should rebase my branch and then run the checks again? |
Contributor
@koprok Could you test to install |
Contributor
|
/azp run |
Contributor
Author
|
@JackBoosY I can install libxslt without any problems. Here is the log from my PC: |
Contributor
Author
|
@JackBoosY, now after this branch builds also on Windows, could you please review it again? |
JackBoosY
suggested changes
Dec 16, 2019
Contributor
JackBoosY
left a comment
JackBoosY
left a comment
There was a problem hiding this comment.
Since the port boost-modular-build-helper has changed, please correct its version in the file CONTROL.
See documentation.
JackBoosY
suggested changes
Dec 16, 2019
Contributor
Author
|
@JackBoosY, about the VCPKG_TARGET_IS_WINDOWS changes. I know that MinGW is not officially supported in Vcpkg. But anyway, can you suggest some better way to make difference between Windows/MSVC and Windows/MinGW? When building with MinGW toolchain, the target is still Windows, so this if statement is a little bit misleading, although it works fine in this case. |
Contributor
|
/azp run |
JackBoosY
approved these changes
Dec 17, 2019
Contributor
|
When buiding libraqm:x64-windows-static: |
koprok
force-pushed
the
mingw
branch
3 times, most recently
from
5333c35 to
8d85db0
Compare
Contributor
Author
This is not related to my MinGW changes, but it is easy to fix, so I have pushed a new commit to fix it. |
Contributor
Author
|
@JackBoosY, so everything builds successfully again. Is it anything more I can do to get this merged into master? :-) |
JackBoosY
approved these changes
Dec 18, 2019
Contributor
Author
|
@JackBoosY, all pipelines should be passing now. OS X fails because of some error not related to the code. |
Contributor
|
@koprok I will test it manually. |
Contributor
|
/azp run |
Contributor
|
When building fribidi, error shows: |
Contributor
Author
@JackBoosY this looks to me like some issue with the build environment that you are using |
Member
|
/azp run |
|
Pull request contains merge conflicts. |
…ser port System include path was added first on compiler command line. This leads to build failure when there is a tmx.h header file in system include path.
Contributor
Author
|
@JackBoosY, @vicroms, all pipelines have passed, finally! Ready to merge now? |
JackBoosY
approved these changes
Feb 1, 2020
Contributor
|
@koprok Did you test the related features(such as ffmpeg)? |
Contributor
Author
|
@JackBoosY, I have tested only glew. Zlib, bzip2 and ffmpeg are dependencies that are needed by some other libraries that I use. For now it is enough for my project that these can be built successfully with MinGW, but I have not tested them personally. Later maybe I will actually use ffmpeg, but the first step is to be able to build it, right? :) |
JackBoosY
added
the
info:needs-maintainer-attention
Contributor
|
/azp run |
1 similar comment
Contributor
|
/azp run |
JackBoosY
removed
the
info:needs-maintainer-attention
JackBoosY
suggested changes
Feb 7, 2020
Contributor
JackBoosY
left a comment
JackBoosY
left a comment
There was a problem hiding this comment.
Can you remove the following content from VCPKG_PATH/scirpts/ci.baseline.txt?
kd-soap:x64-linux=fail
jsonnet:x64-osx=fail
Contributor
|
Awesome work, thanks everyone! |
KineticTheory
pushed a commit
to KineticTheory/vcpkg
that referenced
this pull request
Feb 17, 2020
* Some package fixes necessary to build with MinGW toolchain * [libraqm] Fix build error caused by trying to write to source directory * [tmxparser] Fix build failure when tmx port is intalled before tmxparser port System include path was added first on compiler command line. This leads to build failure when there is a tmx.h header file in system include path. * [qt5-base][angle] Trigger CI rebuild * [kd-soap] Fix build error * Update ci.baseline Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes necessary to build some packages with MinGW toolchain in Debian 9. Custom triplet file and CMake toolchain file is not included.