Skip to content

[imgui] Add feature internal to add imgui_internal.h#9125

Closed
AlvinZhangH wants to merge 2 commits intomicrosoft:masterfrom
AlvinZhangH:dev/alvin/6665
Closed

[imgui] Add feature internal to add imgui_internal.h#9125
AlvinZhangH wants to merge 2 commits intomicrosoft:masterfrom
AlvinZhangH:dev/alvin/6665

Conversation

@AlvinZhangH
Copy link
Contributor

Related issue: #6665.

  1. Add feature internal to use the imgui_internal.h header.
  2. Feature example of this port triplet x86-windows install failed on master branch, and same on my branch.

Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to discuss whether we should merge this PR.

Related: #8788 #9103.

@JackBoosY JackBoosY requested a review from grdowns November 29, 2019 07:48
@AlvinZhangH AlvinZhangH marked this pull request as ready for review January 6, 2020 09:24
@JackBoosY
Copy link
Contributor

/azp run

@JackBoosY
Copy link
Contributor

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.

@JackBoosY JackBoosY closed this May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants