Skip to content

[imgui]Set imgui as a header-only library.#8788

Closed
JackBoosY wants to merge 7 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/imgui_header_only
Closed

[imgui]Set imgui as a header-only library.#8788
JackBoosY wants to merge 7 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/imgui_header_only

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Oct 29, 2019

According to imgui official description:

The core of Dear ImGui is self-contained within a few platform-agnostic files which you can easily copy and compile into your application/engine. They are all the files in the root folder of the repository (imgui.cpp, imgui.h, imgui_demo.cpp, imgui_draw.cpp etc.).

No specific build process is required. You can add the .cpp files to your existing project.

Since most ports that rely on it use it directly from the source code and include -internal.h, try changing this port to a header-only port.

Waiting for #1713 discussion result.

@JackBoosY
Copy link
Contributor Author

/azp run

@helynranta
Copy link
Contributor

Hey,

can you show me an example how to link properly (against examples, like vulkan+sdl) with your version of package and how is it better way. In my mind it is better to explicitly fetch version with features (or support) for different pipelines, in which case it also uses depends functionality. Then only thing when compiling is link against imgui::imgui and all symbols are found.

Now when I use your branch, I´m getting a lot of lnk2019, because cpp files for examples are not found. What is the intended way of using this header-only library when linking against example pipelines?

@JackBoosY
Copy link
Contributor Author

JackBoosY commented Dec 17, 2019

@lerppana Please see my comments above.
Since the port is explicitly declared as a header-only library, I think it is better to use the include method.
And This PR is still wip, I need more work to fix its compatibility.

@helynranta
Copy link
Contributor

I closed my PR in favour of this one, can you also update imgui version with this PR

@JackBoosY JackBoosY marked this pull request as ready for review December 27, 2019 09:31
@JackBoosY
Copy link
Contributor Author

/azp run

1 similar comment
@JackBoosY
Copy link
Contributor Author

/azp run

@JackBoosY
Copy link
Contributor Author

/azp run

@PhoebeHui
Copy link
Contributor

@JackBoosY, could you resolve the conflicts?

@JackBoosY JackBoosY closed this May 14, 2020
@JackBoosY JackBoosY deleted the dev/jack/imgui_header_only branch December 18, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants