[imgui] Updated to 1.74 and added features for sdl2 and vulkan#9103
Closed
helynranta wants to merge 9 commits intomicrosoft:masterfrom
Closed
[imgui] Updated to 1.74 and added features for sdl2 and vulkan#9103helynranta wants to merge 9 commits intomicrosoft:masterfrom
helynranta wants to merge 9 commits intomicrosoft:masterfrom
Conversation
helynranta
commented
Nov 26, 2019
| example IMGUI_COMPILE_ALL_EXAMPLES | ||
| ) | ||
|
|
||
| if ("example" IN_LIST FEATURES AND ("sdl2" IN_LIST FEATURES OR "vulkan" IN_LIST FEATURES)) |
Contributor
Author
There was a problem hiding this comment.
after vcpkg_check_features there must be better way of checking for this
Contributor
|
I have a PR #8788 to solve this issue. |
PhoebeHui
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated library to latest 1.74 and added separate features for sdl2 and Vulkan.
To not break old functionality I added check for not using feature "extra" with sdl2 and vulkan. Extra is windows only feature (sln solution for a lot of stuff in extras folder, including content in these two other features), where as sdl2 and vulkan are just implementation example bindings made by library developers.