Skip to content

[fmt] Disable warning C4189 on Visual Studio 2015#9121

Merged
dan-shaw merged 1 commit intomicrosoft:masterfrom
LilyWangL:dev/Lily/issue9120
Jan 6, 2020
Merged

[fmt] Disable warning C4189 on Visual Studio 2015#9121
dan-shaw merged 1 commit intomicrosoft:masterfrom
LilyWangL:dev/Lily/issue9120

Conversation

@LilyWangL
Copy link
Contributor

Warning C4189 has been fixed in Visual Studio 2017 and Visual Studio 2019. Disable this warning in Visual Studio 2015.
Related issue: #9120
There are no features of this port need to test.

@JackBoosY JackBoosY marked this pull request as ready for review November 29, 2019 03:07
@dan-shaw dan-shaw added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 11, 2019
@dan-shaw dan-shaw assigned dan-shaw and unassigned vicroms Dec 11, 2019
@dan-shaw dan-shaw merged commit 153cab7 into microsoft:master Jan 6, 2020
@dan-shaw dan-shaw mentioned this pull request Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants