[fmt] Update to 7.0.2 + [spdlog] Update to 1.7.0

[kevinlul]

• What does your PR fix? Regular port update for {fmt}

• Which triplets are supported/not supported? Have you updated the CI baseline?
  This causes a regression in spdlog because it uses the fmt implementation namespace, which was renamed from internal to detail in 7.0.0. I believe this can be resolved by defining the FMT_USE_INTERNAL macro according to the release notes, so I guess I should patch spdlog to add this define?

• Does your PR follow the maintainer guide? Yes

[NancyLi1013]

Hi @kevinlul
Thanks for your update.
The regressions for spdlog are due to this:

D:\buildtrees\spdlog\src\ac81386604-c2374a7a41\include\spdlog/details/fmt_helper.h(37): error C2039: 'internal': is not a member of 'fmt'
D:\installed\x86-windows\include\fmt/format.h(234): note: see declaration of 'fmt'
D:\buildtrees\spdlog\src\ac81386604-c2374a7a41\include\spdlog/pattern_formatter-inl.h(65): note: see reference to function template instantiation 'unsigned int spdlog::details::fmt_helper::count_digits<T>(T)' being compiled
        with
        [
            T=size_t
        ]

D:\buildtrees\spdlog\src\ac81386604-c2374a7a41\include\spdlog/details/fmt_helper.h(37): error C3083: 'internal': the symbol to the left of a '::' must be a type
D:\buildtrees\spdlog\src\ac81386604-c2374a7a41\include\spdlog/details/fmt_helper.h(37): error C2039: 'count_digits': is not a member of 'fmt'

Could you please look into these and try to fix them?

[NancyLi1013]

Hi @kevinlul
Thanks for looking into this so quickly.
For current status, we prefer to use a patch to fix the problem in spdlog. We can remove the patch in next spdlog release.
Since we don't know how long we need to wait for the next released version.

[AlexAUT]

spdlog 1.7.0 was just released with support for fmt 7.x https://github.com/gabime/spdlog/releases/tag/v1.7.0

[anand-bala]

@kevinlul For Windows, the definition should be /DFMT_USE_INTERNAL I think

[NancyLi1013]

The new regressions for quill:

D:\buildtrees\quill\src\76aaafff6d-cac280987f.clean\quill\include\quill/detail/BackendWorker.h(250): error C2220: the following warning is treated as an error
D:\buildtrees\quill\src\76aaafff6d-cac280987f.clean\quill\include\quill/detail/BackendWorker.h(250): warning C4530: C++ exception handler used, but unwind semantics are not enabled. Specify /EHsc

[kevinlul]

quill patch should be done. Let's see what the CI thinks!

[NancyLi1013]

If all checks have passed on CI. Could you please also test these features? Please make sure they can work on x86-windows, x64-windows and x64-windows-static, x64-linux triplets except for some special cases, such as the ports doesn't support some specific triplets.

Thanks.

[kevinlul]

I think the build failures are from the current state of master.

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kevinlul]

Need to bump to 7.0.2 in a bit

[NancyLi1013]

Have you test these features in this PR?

[kevinlul]

Yes

[strega-nil]

Since quill has been updated to support fmt::detail, we don't need to worry about patching this anymore.

[kevinlul]

Guess that happens given enough time 😅 but I think with your last revert a bunch of whitespace got readded to a blank line in the quill portfile.

[strega-nil]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[strega-nil]

Yeah, I think that's fine :)

[strega-nil]

Thanks so much for your patience and work in pushing this forward @kevinlul !