Skip to content

[fmt] Update to 6.1.2#9289

Closed
kevinlul wants to merge 6 commits intomicrosoft:masterfrom
kevinlul:fmt-6.1.2
Closed

[fmt] Update to 6.1.2#9289
kevinlul wants to merge 6 commits intomicrosoft:masterfrom
kevinlul:fmt-6.1.2

Conversation

@kevinlul
Copy link
Contributor

No description provided.

@NancyLi1013
Copy link
Contributor

@kevinlul thanks for the PR.

Failing on the Windows CI:

CMake Error at ports/fmt/portfile.cmake:24 (file):
  file RENAME failed to rename

    C:/vsts/_work/3/s/packages/fmt_x86-windows/debug/lib/fmtd.dll

  to

    C:/vsts/_work/3/s/packages/fmt_x86-windows/debug/bin/fmtd.dll

  because: File exists

Call Stack (most recent call first):
  scripts/ports.cmake:94 (include)

As bin/fmtd.dll has existed, it cannot be renamed again.

Failing on the Linux CI:

l-inl.h: In member function ‘bool spdlog::details::thread_pool::process_next_msg_()’:
/ci/myagent/_work/3/s/buildtrees/spdlog/src/34724392a0-c671dd4aa9/include/spdlog/details/thread_pool-inl.h:119:9: error: ‘assert’ was not declared in this scope
         assert(false && "Unexpected async_msg_type");
         ^~~~~~
compilation terminated due to -Wfatal-errors.

spdlog failed on the Linux due to above reason.

Please take a look and try to fix them.

@NancyLi1013
Copy link
Contributor

What does this PR fix? Please open an issue so others may replicate this problem.

@kevinlul
Copy link
Contributor Author

This is a simple package update to the latest version of {fmt}

@dan-shaw dan-shaw self-assigned this Dec 13, 2019
@dan-shaw
Copy link
Contributor

@kevinlul LGTM, still waiting for the MacOS pipeline

@kevinlul
Copy link
Contributor Author

kevinlul commented Dec 13, 2019

I don't know about the spdlog regression on all platforms or the Windows arm triplet failures.

@NancyLi1013
Copy link
Contributor

@kevinlul The failures on Windows platform from CI system:
C:\vsts\_work\3\s\buildtrees\spdlog\src\34724392a0-c671dd4aa9\include\spdlog/details/thread_pool-inl.h(119): error C3861: 'assert': identifier not found

C:\vsts\_work\3\s\buildtrees\spdlog\src\34724392a0-c671dd4aa9\include\spdlog/details/pattern_formatter-inl.h(76): error C3861: 'assert': identifier not found

The failures on Linux are the same as those on Windows.

@NancyLi1013 NancyLi1013 self-assigned this Dec 17, 2019
@JackBoosY
Copy link
Contributor

/azp run

@dan-shaw
Copy link
Contributor

dan-shaw commented Jan 6, 2020

@kevinlul I've just merged #9121, which may fix the regressions in the CI. Can you check?

@kevinlul kevinlul requested a review from NancyLi1013 January 7, 2020 00:33
@kevinlul
Copy link
Contributor Author

kevinlul commented Jan 9, 2020

Doesn't look like it.

@NancyLi1013
Copy link
Contributor

/azp run

@JackBoosY
Copy link
Contributor

/azp run

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Jan 19, 2020

It seems that there is something wrong with patch now.
I got the error info on windows platform from CI test result:

Checking patch include/fmt/format.h...
error: while searching for:
#ifndef FMT_FORMAT_H_
#define FMT_FORMAT_H_

#include <algorithm>
#include <cassert>
#include <cmath>

error: patch failed: include/fmt/format.h:33
error: include/fmt/format.h: patch does not apply

Could you please help check?

@NancyLi1013
Copy link
Contributor

/azp run

@NancyLi1013
Copy link
Contributor

The regressions on Linux and Windows caused by spdlog still exist.

Could you take a look?

@kevinlul
Copy link
Contributor Author

Closing due to redundancy with two other PRs.

@kevinlul kevinlul closed this Feb 19, 2020
@kevinlul kevinlul deleted the fmt-6.1.2 branch March 7, 2020 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants