[loguru] Update to 2.1.0 and extend to generate proper binary on non-windows#8682
Conversation
|
/azp run |
|
/azp run |
2 similar comments
|
/azp run |
|
/azp run |
|
@vicroms, could you please priority to review and merge this PR? |
|
@PhoebeHui I have a problem with your I believe it would be necessary to also pull the implementation like I did in my pull request. If you have another way of making this work with your version, let me know and I might be happy. |
|
@BullyWiiPlaza, thanks for bringing this up, I will take a look. |
|
@@BullyWiiPlaza, the PR has been merged, please get vcpkg source and try again. |
|
@PhoebeHui For Windows it's working fine now but for Linux the |
|
@BullyWiiPlaza, loguru is not header-only on linux now, it provides cmake targets on linux, you can use it, let me know if you encounter some issues about it. |
|
@PhoebeHui Just to clarify, the Yes, including the |
|
@BullyWiiPlaza, sorry for my late reply, I will take a look at this issue again. |
Related to #8158
Loguru is not a header-only library any more, however, the source doesn't export to the lib on windows, so only install header on windows.
loguru has no feature that need to test locally.