[loguru] bumped to 2.1.0#9758
Closed
BullyWiiPlaza wants to merge 1 commit intomicrosoft:masterfrom
BullyWiiPlaza:master
Closed
[loguru] bumped to 2.1.0#9758BullyWiiPlaza wants to merge 1 commit intomicrosoft:masterfrom BullyWiiPlaza:master
BullyWiiPlaza wants to merge 1 commit intomicrosoft:masterfrom
BullyWiiPlaza:master
Conversation
|
|
Contributor
|
@BullyWiiPlaza, thanks for the PR! There is a exist PR #8682 to upgrade loguru to 2.1.0. |
Contributor
Author
|
@PhoebeHui Oh, excuse me. I searched for loguru but your PR didn't show up before. It's been a while since you submitted your PR so I'm wondering why it takes so long to accept PRs like these? It would be crucial for the package manager to somewhat stay up-to-date. |
Contributor
|
@BullyWiiPlaza, the CI testing system offline for maintenance previously that blocked that PR for a long time, we will priority to merge that PR! |
Contributor
|
@BullyWiiPlaza, the PR #8682 has been merged. Is that ok to close this PR? |
Contributor
Author
|
@PhoebeHui Yes, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
I had trouble successfully using the library before the update since the
loguru.cppfile was missing which needs to be included once somewhere in the code base (counterintuitively). After that, theloguru.hppcan be included as often as one wants.Which triplets are supported/not supported? Have you updated the CI baseline?
I only bumped up the version.
Does your PR follow the maintainer guide?
Yes.