Skip to content

[loguru] Fix link issue#10050

Merged
strega-nil merged 1 commit intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/loguru
Mar 11, 2020
Merged

[loguru] Fix link issue#10050
strega-nil merged 1 commit intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/loguru

Conversation

@PhoebeHui
Copy link
Contributor

Fix link issue that in #8682 (comment)

loguru is header only librariy on windows, it's need loguru.cpp file when use it base on https://github.com/emilk/loguru#compiling, so also install loguru.cpp file.

@PhoebeHui
Copy link
Contributor Author

/azp run

1 similar comment
@PhoebeHui
Copy link
Contributor Author

/azp run

@JackBoosY JackBoosY marked this pull request as ready for review February 20, 2020 13:44
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Feb 20, 2020
@strega-nil
Copy link
Contributor

Alright, this looks good to me :)

@strega-nil strega-nil merged commit 330ef69 into microsoft:master Mar 11, 2020
Toxe pushed a commit to Toxe/vcpkg that referenced this pull request Mar 11, 2020
Toxe added a commit to Toxe/vcpkg that referenced this pull request Mar 11, 2020
@PhoebeHui PhoebeHui deleted the dev/Phoebe/loguru branch March 11, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants