Skip to content

Fix MSYS hanging of PowerShell#6729

Merged
grdowns merged 2 commits intomicrosoft:masterfrom
emptyVoid:fix-vcpkg_acquire_msys
Jun 5, 2019
Merged

Fix MSYS hanging of PowerShell#6729
grdowns merged 2 commits intomicrosoft:masterfrom
emptyVoid:fix-vcpkg_acquire_msys

Conversation

@emptyVoid
Copy link
Contributor

Fixes #6688.

I moved gpg-agent.exe termination code from #6407 into vcpkg_acquire_msys so that none of the ports using MSYS would block build automation tools.

@NancyLi1013
Copy link
Contributor

Hi @emptyVoid, thanks for your PR. Could you please also bump the version in CONTROL version?

@emptyVoid
Copy link
Contributor Author

@NancyLi1013, do you mean ports/icu/CONTROL file?

@NancyLi1013
Copy link
Contributor

Yes, you're right. if there are some changes about the port, you should also update the version in ports/port/CONTROL file. Thanks.

@emptyVoid
Copy link
Contributor Author

Same errors as with #6723:

error: failed to update mingw32 (unable to lock database)
error: failed to update mingw64 (unable to lock database)
error: failed to update msys (unable to lock database)
error: failed to synchronize all databases

@Rastaban
Copy link
Contributor

Rastaban commented Jun 4, 2019

It looks like when the task is killed it does not free its lock on the database. Because we are reusing VMs in the CI system the lock is causing failures in unrelated PRs.

@grdowns
Copy link
Contributor

grdowns commented Jun 4, 2019

We'll want to trigger a rebuild of all ports using vcpkg_acquire_msys before putting this change through. Thanks @emptyVoid!

@vicroms
Copy link
Member

vicroms commented Jun 4, 2019

Waiting on CI results from #6760 where I added white-space changes to trigger CI builds of ports using MSYS.

@grdowns grdowns self-assigned this Jun 4, 2019
@grdowns
Copy link
Contributor

grdowns commented Jun 5, 2019

#6760 has finished and this PR is now passing Eager. Thanks again for this fix, @emptyVoid!

@grdowns grdowns merged commit a2dbe32 into microsoft:master Jun 5, 2019
@emptyVoid emptyVoid deleted the fix-vcpkg_acquire_msys branch June 5, 2019 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MSYS based builds hang PowerShell

5 participants