[FFmpeg] Add support for VP8/VP9 codecs#6784
Merged
cbezault merged 1 commit intomicrosoft:masterfrom Jun 10, 2019
Merged
Conversation
Contributor
Author
|
Same errors again (see #6729 (comment)): |
c4fe21d to
9ff0383
Compare
Contributor
|
Sorry about those database locking errors, we're working on ironing them out. I just want to make sure that this PR is only meant to enable VP8/VP9 on Windows right? |
Contributor
Author
|
Yes, enabling VP8/VP9 on Windows only. Should work for other platforms too, though |
Contributor
|
I'm going to allow this for now because it works for you and doesn't break anything else but the mechanism you are using to detect whether or not we're compiling a debug library will only work on windows. A better fix would have been to work on the upstream port. I'm going to be doing just that for BZip2 to get it to work with ffmpeg without the kind of patching you did so I might revisit this then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
vpxfeature toffmpegto support WebM VP8/VP9 codecs.Resolves #6449.