[icu] Prevent stale MSYS gpg-agent.exe process blocking command control#6407
[icu] Prevent stale MSYS gpg-agent.exe process blocking command control#6407vicroms merged 2 commits intomicrosoft:masterfrom heydojo:patch-1
Conversation
This commit fixes: #5476 The issue is that CI environments such as Appveyor's VS2017 image will wait for all processes to complete. If a stale process resides as a result, builds will hang. There does not appear to be any good reason for gpg-agent.exe to be running once the build of icu has completed. Without this patch builds of icu4c using CI systems will very likely hang and not in an obvious way. Is this the _right_ solution to this problem? Probably not but it is one solution. And it degrades gracefully in that the build will not fail if gpg-agent.exe is not running. The gpg-agent.exe will not run again once MSYS has been configured, so to test this patch, a fresh install of vcpkg is required. Open the task manager and before the icu build completes, look for gpg-agent.exe just sitting there for no reason. Might I suggest that the issue is fixed in vcpkg MSYS instead or as well? Please don't request further from this commit.
|
No way I'm logging into another account just to look at an Azure pipeline log. Please feel free to reject, refactor and or resubmit this commit. I'll leave the fork up for about a month. |
|
Hi @heydojo, thanks for your new PR. I see some regressions from the current CI system:
Please let us know if you need any help. |
|
@NancyLi1013 unfortunately @heydojo said "Please don't request further from this commit."... whoever has writing permissions to this PR should continue the work and finish it. It should be enough to wrap the added lines inside a |
|
Thanks for your contribution @heydojo ! I'm sorry that the project didn't meet your expectations. If you're willing to provide feedback regarding your decision to move away from |
This commit fixes:
#5476
The issue is that CI environments such as Appveyor's VS2017 image will wait for all processes to complete. If a stale process resides as a result, builds will hang.
There does not appear to be any good reason for gpg-agent.exe to be running once the build of icu has completed.
Without this patch builds of icu4c using CI systems will very likely hang and not in an obvious way.
Is this the right solution to this problem? Probably not but it is one solution. And it degrades gracefully in that the build will not fail if gpg-agent.exe is not running. The gpg-agent.exe will not run again once MSYS has been configured, so to test this patch, a fresh install of vcpkg is required. Open the task manager and before the icu build completes, look for gpg-agent.exe just sitting there for no reason.
Might I suggest that the issue is fixed in vcpkg MSYS instead or as well?
Please don't request further from this commit.