[wip] Fix CMAKE_SYSTEM_PROCESSOR (Resubmission of #4688)#5697
Closed
[wip] Fix CMAKE_SYSTEM_PROCESSOR (Resubmission of #4688)#5697
Conversation
Add CMAKE_SYSTEM_PROCESSOR setting under UWP, Linux, and Darwin. If explicitly specified VCPKG_CMAKE_SYSTEM_PROCESSOR in triplet files, CMAKE_SYSTEM_PROCESSOR is set to specified architecture.
…n/vcpkg into pr/viromer/fix-cmake-system-processor
Closed
Member
Author
Current Regressions Status
|
Contributor
|
For darknet static I can open a PR. It is just a matter of a bug in the findpthreads_windows.cmake which is fixed in a PR upstream ( we are still testing it) and which I can submit also here. It should not have passed CI tests for static from the beginning... |
Contributor
|
also many of those ports are fixed in my #5169 PR, if you don't want to duplicate efforts |
Member
Author
…iromer/fix-cmake-system-processor
…iromer/fix-cmake-system-processor
…iromer/fix-cmake-system-processor
…iromer/fix-cmake-system-processor
…omer/fix-cmake-system-processor
This was referenced May 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
#4970
#4688
#5218
#4688 was reverted due to regressions
Quoting @UnaNancyOwen: