vcpkg: fix toolchain to correctly set the CMAKE_SYSTEM_PROCESSOR vari…#4970
Closed
studiofuga wants to merge 1 commit intomicrosoft:masterfrom
Closed
vcpkg: fix toolchain to correctly set the CMAKE_SYSTEM_PROCESSOR vari…#4970studiofuga wants to merge 1 commit intomicrosoft:masterfrom
studiofuga wants to merge 1 commit intomicrosoft:masterfrom
Conversation
…able Some build fails because cmake expects the CMAKE_SYSTEM_PROCESSOR to be correctly set with the system processor flavour. scripts/toolchains/linux.cmake fails to set it, while other toolchains correctly set it (see osx.cmake) for example. This patch fix this bug.
Closed
Contributor
|
I am seeing new build failures on the following ports with this PR. Let me know if you need build log. |
Contributor
|
This would probably fix issues currently seen on #4635 |
Member
|
I had an open PR to address this same issue, but it got closed when we deleted all the branches on this repo. I'll resubmit it once I have more time to keep working on the issue. |
Member
|
Fixed in #6872 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…able
Some build fails because cmake expects the CMAKE_SYSTEM_PROCESSOR to
be correctly set with the system processor flavour.
scripts/toolchains/linux.cmake fails to set it, while other
toolchains correctly set it (see osx.cmake) for example.
This patch fix this bug.