WIP [vcpkg] Fix CMAKE_SYSTEM_PROCESSOR with UWP and Linux triplets#4688
Merged
ras0219-msft merged 3 commits intomicrosoft:masterfrom Nov 20, 2018
Merged
WIP [vcpkg] Fix CMAKE_SYSTEM_PROCESSOR with UWP and Linux triplets#4688ras0219-msft merged 3 commits intomicrosoft:masterfrom
ras0219-msft merged 3 commits intomicrosoft:masterfrom
Conversation
UnaNancyOwen
force-pushed
the
add_system_processor
branch
from
ecd2b23 to
42f8878
Compare
UnaNancyOwen
changed the title
UnaNancyOwen
force-pushed
the
add_system_processor
branch
from
42f8878 to
26b62df
Compare
UnaNancyOwen
changed the title
UnaNancyOwen
changed the title
Add CMAKE_SYSTEM_PROCESSOR setting under UWP, Linux, and Darwin. If explicitly specified VCPKG_CMAKE_SYSTEM_PROCESSOR in triplet files, CMAKE_SYSTEM_PROCESSOR is set to specified architecture.
UnaNancyOwen
force-pushed
the
add_system_processor
branch
from
26b62df to
07c910c
Compare
Contributor
Author
|
@alexkaratarakis @ras0219-msft Can I get your opinion? |
Contributor
|
Thanks for the investigation and the PR! I tried to move as much "logic" as possible into the toolchains themselves and kept only the toolchain agnostic pieces in the main configure command. Note that Linux and Windows actually have different settings for |
Contributor
|
Ok, this unfortunately resulted in some regressions after merging; I've temporarily reverted the PR but I'll investigate and let you know what I discover. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of UWP and Linux triplets,
CMAKE_SYSTEM_PROCESSORis not specified. It is empty.For details this problems, Please refer to this comment #4635 (comment).
This pull request will set
CMAKE_SYSTEM_PROCESSORunder UWP and Linux triplets.If you want to explicitly specified CPU arcitecture, You can use
VCPKG_CMAKE_SYSTEM_PROCESSORin triplet files.