Skip to content

[qtwebengine] Fix build, add features for pdf and webengine#46162

Merged
vicroms merged 24 commits into
microsoft:masterfrom
dg0yt:qtwebengine
Jul 14, 2025
Merged

[qtwebengine] Fix build, add features for pdf and webengine#46162
vicroms merged 24 commits into
microsoft:masterfrom
dg0yt:qtwebengine

Conversation

@dg0yt
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt commented Jun 25, 2025

Qt PDF can be built for static triplets. Except for windows: It doesn't allow to use system (vcpkg) libs.

@nickdademo
Copy link
Copy Markdown
Contributor

Will this also fix #45200? :)

I am getting this error for windows-x64 and am using this port overlay as a fix: https://github.com/jblaisdev/vcpkg-qtwebengine-overlay

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Jun 25, 2025

Will this also fix #45200? :)

No, I don't think so. I only test Linux ATM. The non-Window side of this port is quite different, with use of more vcpkg libs.

But this work started from a Windows issue blocking #46058. That error is probably from using vcpkg protobuf headers with a vendored protobuf, due to the order of include directories. protobuf is also in #45807.

Maybe the order of include directories is also relevant for other problems, such as #45200?

@Mengna-Li Mengna-Li added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-bug The issue is with a library, which is something the port should already support labels Jun 26, 2025
@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Jul 6, 2025

Absolute path in

\$<LINK_ONLY:\$<1:-Wl,--no-fatal-warnings \$<\$<CONFIG:Release>:@/[REDACTED]/vcpkg/buildtrees/qtwebengine/x64-linux-rel/src/pdf/Release/x86_64/QtPdf_ldir.rsp> \$<\$<CONFIG:Release>:@/[REDACTED]/vcpkg/buildtrees/qtwebengine/x64-linux-rel/src/pdf/Release/x86_64/QtPdf_libs.rsp> -Wl,--no-fatal-warnings>>

... a response file, seriously?

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Jul 6, 2025

The first one only carries

 -L"/[REDACTED]/vcpkg/installed/x64-linux/lib"

but the second has

 -latomic -licuuc -licudata -lstdc++ -lm -lpthread -lpng16 -lz -lgmodule-2.0 -lgobject-2.0 -lffi -lgthread-2.0 -lglib-2.0 -lpcre2-8 -lopenjp2

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Jul 6, 2025

Test ports. Discovered that pdfium wasn't using the system (vcpkg) libjpeg-turbo, resulting in duplicate symbols.

@dg0yt
Copy link
Copy Markdown
Contributor Author

dg0yt commented Jul 9, 2025

nodejs on arm64-osx:

CMake Error at ports/qtwebengine/portfile.cmake:138 (execute_process):
  execute_process failed command indexes:

    1: "Abnormal exit with child return code: Subprocess killed"

Call Stack (most recent call first):
  scripts/ports.cmake:206 (include)

'/Users/vcpkg/Data/installed/arm64-osx/tools/node/bin/node' '--version'

@dg0yt dg0yt marked this pull request as ready for review July 11, 2025 14:26
)

set(TOOL_NAMES gn QtWebEngineProcess qwebengine_convert_dict webenginedriver)
list(REMOVE_ITEM FEATURES "private-dependencies")
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
list(REMOVE_ITEM FEATURES "private-dependencies")

Left over, but I don't want to rebuild.

@vicroms vicroms merged commit d55efd2 into microsoft:master Jul 14, 2025
18 checks passed
@dg0yt dg0yt deleted the qtwebengine branch July 15, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants